Fix docker tests #5508
Merged
Fix docker tests #5508
8000
TravisEz13
requested review from
adityapatwardhan and
daxian-dbw
as code owners
November 20, 2017 18:30
daxian-dbw
left a comment
TravisEz13
force-pushed
the
fix_docker_tests
branch
from
November 21, 2017 00:05
TravisEz13
force-pushed
the
fix_docker_tests
branch
from
November 21, 2017 21:11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@TravisEz13 Can you add in the description why openSUSE and AmazonLinux were removed? |
daxian-dbw
approved these changes
Nov 20, 2017
Member
There was a problem hiding this comment.
@adityapatwardhan AmazonLinux and openSUSE are removed because we don't publish docker images for these 2 distros for now.
Member
|
@TravisEz13 I think we should always target the master branch, and cherrypick commits to 6.0.0 branch, right? |
cacdb8d to
165b8a4
Compare
165b8a4 to
a1af5f0
Compare
Member
Author
|
Marking for GA so we can test docker correctly for GA |
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 21, 2017
* update expected version * update container list
Merged
TravisEz13
added a commit
that referenced
this pull request
Nov 21, 2017
* update expected version * update container list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSUSEandamazonlinuxas they are not community images and not published.