Add macos launcher. #5138
Merged
Add macos launcher. #5138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
reviewed
Oct 17, 2017
| <key>CFBundleIdentifier</key> | ||
| <string>powershell</string> | ||
| <key>CFBundleInfoDictionaryVersion</key> | ||
| <string>6.0</string> |
Member
There was a problem hiding this comment.
should we be replacing any of these versions, with the one from the version/release tag?
Contributor
Author
There was a problem hiding this comment.
That value is related to the plist definition itself and should not change.
TravisEz13
reviewed
Oct 17, 2017
Member
There was a problem hiding this comment.
looks good, just one question about the version
TravisEz13
approved these changes
Oct 17, 2017
Collaborator
|
@TravisEz13 Is the PR ready to merge? |
adityapatwardhan
added a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Oct 27, 2017
This reverts commit 01fe7c2.
daxian-dbw
pushed a commit
that referenced
this pull request
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds macOS application to launch PowerShell.
Close #5074