Add a CR to CommandNotFoundException error string #4934

jpsnover · 2017-09-27T18:37:29Z

We're here at PowerShell Unplugged at Ignite, and this error message could really use a carriage return!

We're here at PowerShell Unplugged at Ignite, and this error message could *really* use a carriage return!

SteveL-MSFT

Thanks for the contribution, but string resources should not contain newlines as it may produce unexpected results when it goes through FormatAndOutput

SteveL-MSFT · 2017-09-27T19:11:48Z

src/System.Management.Automation/resources/DiscoveryExceptions.resx

@@ -136,7 +136,8 @@
    <value>Cannot retrieve an instance of CommandDiscovery.</value>
  </data>
  <data name="CommandNotFoundException" xml:space="preserve">
-    <value>The term '{0}' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.</value>
+    <value>The term '{0}' is not recognized as the name of a cmdlet, function, script file, or operable program.


Formatting should be handled by FormatAndOutput. String messages should not contain newlines.

Perhaps adding new newlines is something we should consider for other strings as it can improve readability.

iSazonov · 2017-10-02T07:25:15Z

Please clarify what was idea here.
Before the change:

> qwerty
qwerty : The term 'qwerty' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path
was included, verify that the path is correct and try again.
At line:1 char:1
+ qwerty
+ ~~~~~~
    + CategoryInfo          : ObjectNotFound: (qwerty:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

After the change:

PS C:\Users\sie\Documents\GitHub\iSazonov\PowerShell> qwerty
qwerty : The term 'qwerty' is not recognized as the name of a cmdlet, function, script file, or operable program.
      Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ qwerty
+ ~~~~~~
    + CategoryInfo          : ObjectNotFound: (qwerty:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Or idea was to change command line error formatting?
From:

> .\debug\powershell.exe -sma
The argument '-sma' is not recognized as the name of a script file. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

To:

> .\debug\powershell.exe -sma
The argument '-sma' is not recognized as the name of a script file. 
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

iSazonov · 2017-10-03T06:33:40Z

@SteveL-MSFT Could you please clarify?

SteveL-MSFT · 2017-10-03T16:26:15Z

@iSazonov I believe the intent was to have the next sentence on the next line left justified. The whitespace should have been removed. I'll submit PR.

Add a CR to CommandNotFoundException error string

90d4921

We're here at PowerShell Unplugged at Ignite, and this error message could *really* use a carriage return!

SteveL-MSFT requested changes Sep 27, 2017

View reviewed changes

SteveL-MSFT approved these changes Sep 29, 2017

View reviewed changes

daxian-dbw merged commit b9845d5 into master Sep 29, 2017

daxian-dbw deleted the jpsnover-patch-1 branch September 29, 2017 19:16

SteveL-MSFT mentioned this pull request Oct 3, 2017

removed accidental leading whitespace from resx string #4991

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a CR to CommandNotFoundException error string #4934

Add a CR to CommandNotFoundException error string #4934

Add a CR to CommandNotFoundException error string #4934

Add a CR to CommandNotFoundException error string #4934

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment