Modify travis build to upload a daily build badge based on platform #4689
Conversation
README.md
Outdated
| | AppVeyor (Windows) | Travis CI (Linux / macOS) | Code Coverage Status | | ||
| |--------------------------|---------------------------|----------------------| | ||
| | [![av-nightly-image][]][av-nightly-site] | [![tv-nightly-image][]][tv-site] | [![cc-image][]][cc-site] | | ||
| | AppVeyor (Windows) | Travis CI (Linux) | Travis CI (OSX) | Code Coverage Status | |
There was a problem hiding this comment.
I believe Apple has standardized on macOS vs OSX, so we should be consistent with macOS (ignore the fact we have $isOSX, unfortunately it's a breaking change now)
There was a problem hiding this comment.
shouldn't we be rather self consistent? I believe that it will be more confusing for our users unless we also make the change in our variables
There was a problem hiding this comment.
Agree we should be consistent with the variables, but that's outside the scope of this PR. I think at least within the README.md, we can be consistent on using macOS (which it is currently)
There was a problem hiding this comment.
@SteveL-MSFT updated to include this change
There was a problem hiding this comment.
Still shows OSX, did you push?
There was a problem hiding this comment.
@SteveL-MSFT yup
9246c70 to
be8c381
Compare
change README.md to view a platform specific badge
be8c381 to
d08c899
Compare
|
@TravisEz13 can we get this in? |
change README.md to view a platform specific badge
This will give us better visibility into our platform specific builds, and improve efficiency when investigating a build failure