10000 Disable VC++ Redist test and Run Only on Windows by mirichmo · Pull Request #4673 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Disable VC++ Redist test and Run Only on Windows #4673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2017
Merged

Disable VC++ Redist test and Run Only on Windows #4673

merged 1 commit into from
Aug 25, 2017

Conversation

mirichmo
Copy link
Member
@mirichmo mirichmo commented Aug 25, 2017 •
edited
Loading

This PR does two things:

  1. Disable the VC++ redist test that corresponds with the code that I removed during the release process
  2. Execute the tests only on Windows to prevent failures on non-windows systems

It partially addresses #4665
Fixes #4663

@mirichmo mirichmo requested a review from TravisEz13 August 25, 2017 18:19
@mirichmo mirichmo mentioned this pull request Aug 25, 2017
Merged
@daxian-dbw daxian-dbw merged commit c219066 into PowerShell:master Aug 25, 2017
@mirichmo mirichmo deleted the mirichmo-disable-vcpp-redist-test branch August 25, 2017 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

@daxian-dbw daxian-dbw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mirichmo @daxian-dbw @SteveL-MSFT @msftclas
0