8000 Update install scripts with minor fixes targeting macOS by DarwinJS · Pull Request #4631 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Update install scripts with minor fixes targeting macOS #4631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasiona 8000 lly send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Update install scripts with minor fixes targeting macOS #4631

merged 1 commit into from
Aug 22, 2017

Conversation

DarwinJS
Copy link
Contributor
@DarwinJS DarwinJS commented Aug 21, 2017

Fixes #4617
Fixes #4511
Change VS code install to use cask
Change OSX to use curl
Update version number by point release.

test url and version bump

changed git suburl back to production location
@msftclas
Copy link

@DarwinJS,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@TravisEz13
Copy link
Member

Please make sure that you add a meaningful title per the contribution guide.
Please use the present tense, imperative style for commit messages and title per Contribution Guide

@TravisEz13 TravisEz13 changed the title fix issues 4511 and 4617 Update install scripts with minor fixes targeting macOS Aug 21, 2017
@TravisEz13
Copy link
Member

I updated the title to something more appropriate

@TravisEz13
Copy link
Member

When a PR fixes an issues, please include in the description (not title), Fixes #1234. I've updated your PR description for you.

@TravisEz13
Copy link
Member

LGTM, I'll leave this open for comment for about 24 hours.

@TravisEz13 TravisEz13 self-assigned this Aug 21, 2017
@TravisEz13 TravisEz13 merged commit ece7b44 into PowerShell:master Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0