Move to the official .NET Core 2.0 #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
approved these changes
Aug 16, 2017
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| image: Visual Studio 2017 | |||
|
|
|||
| # cache version - netcoreapp.2.0.0-preview3-25426-01 | |||
| # cache version - netcoreapp.2.0.0 | |||
| cache: | |||
| - '%LocalAppData%\Microsoft\dotnet -> appveyor.yml' | |||
There was a problem hiding this comment.
Why don't we update the caches to depend on PowerShell.Common.props. Then we only have one place to update the version.
There was a problem hiding this comment.
There are some changes pending for PowerShell.Common.props (see Ilya's MSBuild refactoring PRs). I think for the time being, PowerShell.Common.props has more churns than appveyor.yml.
|
@daxian-dbw This is a major change, should we run Feature tests? |
|
@adityapatwardhan I requested feature test run for the PR, please take a look at the second commit message. I will investigate failure in appveyor. |
|
There were 11 tests failing in AppVeyor and all are web cmdlet tests. They failed because of time out. |
mirichmo
approved these changes
Aug 17, 2017
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core 2.0 was officially released on 8/14/2017.
This PR is to migrate our tooling and build to the official .NET Core 2.0 bits.