8000 Clean up FullCLR related scripts/docs by daxian-dbw · Pull Request #4580 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Clean up FullCLR related scripts/docs #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitH 8000 ub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2017

Conversation

daxian-dbw
Copy link
Member

Related to #4357

This PR includes following changes:

  1. Remove FulLCLR related build script in build.psm1
  2. Remove commented out FullCLR related scripts in AppVeyor.psm1
  3. Remove FullCLR test file test/fullclr/PowerShellGithubDev.Tests.ps1
  4. Remove FullCLR related doc content.

Copy link
Member
@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comment

{
$Command += "Import-Module '$Pester'; "
}
$Command += "Import-Module '$Pester'; "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this, now that we have module autoloading?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep it as the -Pester parameter can be given a different path than the one in our module path.

Copy link
Member
@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes look good

@adityapatwardhan adityapatwardhan merged commit feeb8e1 into PowerShell:master Aug 16, 2017
@daxian-dbw daxian-dbw deleted the build branch August 16, 2017 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0