8000 Add codeowner files by TravisEz13 · Pull Request #4565 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Add codeowner files #4565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2017
Merged

Add codeowner files #4565

merged 5 commits into from
Aug 15, 2017

Conversation

TravisEz13
Copy link
Member

add codeowner file to automatically assign reviewers and to describe who owns areas.

Copy link
Collaborator
@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicks should be fixed in all file.

# @daxian-dbw @lzybkr @steveL-MSFT @charub

# Area: Language
# daxian-dbw @vors @lzybkr @BrucePay @steveL-MSFT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

daxian-dbw -> @daxian-dbw

# First Lets start with areas with no filters or paths

# Area: Performance
# @lzybkr @steveL-MSFT @adityapatwardhan
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steveL-MSFT -> @SteveL-MSFT

# @BrucePay @JamesWTruher @steveL-MSFT

# Area: Security
# @travisez13 @leeholmes @steveL-MSFT @PaulHigin @chunqingchen
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@travisez13 -> @TravisEz13

@TravisEz13
Copy link
Member Author

I addressed @iSazonov 's feedback

# @BrucePay @JamesWTruher @SteveL-MSFT

# Area: Security
# @TravisEz13 @leeholmes @SteveL-MSFT @PaulHigin @chunqingchen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove Lee and Chunqing

Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove my name from everywhere except demos.

@TravisEz13
Copy link
Member Author

@SteveL-MSFT Updated

src/System.Management.Automation/engine/debugger/ @BrucePay@dantraMSFT @PaulHigin

# Area: help
src/System.Management.Automation/help @@Francisco-Gamino @adityapatwardhan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#Resolved


# Area: Debugging
# Must be below engine to override
src/System.Management.Automation/engine/debugger/ @BrucePay@dantraMSFT @PaulHigin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space between @BrucePay and @dantraMSFT

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved


# Area: Security
# @TravisEz13 @leeholmes @SteveL-MSFT @PaulHigin @chunqingchen
# @TravisEz13 @leeholmes @PaulHigin @chunqingchen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove leeholmes, he isn't generally available so Paul, Travis, or I will pull him in when needed. Remove chunqing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#Resolved

demos/ @joeyaiello @SteveL-MSFT @HemantMahawar

# Area: DSC
src/System.Management.Automation/DscSupport @TravisEz13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add dantraMSFT to DSC as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@iSazonov
Copy link
Collaborator

Travis CI temporary failed - I restarted it.

Copy link
Member
@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TravisEz13 TravisEz13 merged commit 498680a into PowerShell:master Aug 15, 2017
@daxian-dbw
Copy link
Member

+test/ @JamesWTruher @TravisEz13 @adityapatwardhan

Just realized that this cause Jim, Travis and Aditya to be dragged into almost every PR review.
Maybe we shouldn't specify 'test/' in the codeowner file.

@TravisEz13
Copy link
Member Author

Rules later in the file are supposed to override previous rules. Let's see how it actually works before we change it.

@TravisEz13
Copy link
Member Author

But looking at least one PR it looks like it takes the aggregate of what it finds from the rules. Do you want me to submit a PR removing the area-test rule?

@TravisEz13 TravisEz13 deleted the AddOwnership branch September 27, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0