-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add codeowner files #4565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codeowner files #4565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicks should be fixed in all file.
.github/CODEOWNERS
Outdated
# @daxian-dbw @lzybkr @steveL-MSFT @charub | ||
|
||
# Area: Language | ||
# daxian-dbw @vors @lzybkr @BrucePay @steveL-MSFT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
daxian-dbw -> @daxian-dbw
.github/CODEOWNERS
Outdated
# First Lets start with areas with no filters or paths | ||
|
||
# Area: Performance | ||
# @lzybkr @steveL-MSFT @adityapatwardhan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveL-MSFT
-> @SteveL-MSFT
.github/CODEOWNERS
Outdated
# @BrucePay @JamesWTruher @steveL-MSFT | ||
|
||
# Area: Security | ||
# @travisez13 @leeholmes @steveL-MSFT @PaulHigin @chunqingchen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@travisez13
-> @TravisEz13
I addressed @iSazonov 's feedback |
.github/CODEOWNERS
Outdated
# @BrucePay @JamesWTruher @SteveL-MSFT | ||
|
||
# Area: Security | ||
# @TravisEz13 @leeholmes @SteveL-MSFT @PaulHigin @chunqingchen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove Lee and Chunqing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove my name from everywhere except demos.
@SteveL-MSFT Updated |
.github/CODEOWNERS
Outdated
src/System.Management.Automation/engine/debugger/ @BrucePay@dantraMSFT @PaulHigin | ||
|
||
# Area: help | ||
src/System.Management.Automation/help @@Francisco-Gamino @adityapatwardhan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#Resolved
.github/CODEOWNERS
Outdated
|
||
# Area: Debugging | ||
# Must be below engine to override | ||
src/System.Management.Automation/engine/debugger/ @BrucePay@dantraMSFT @PaulHigin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space between @BrucePay and @dantraMSFT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
.github/CODEOWNERS
Outdated
|
||
# Area: Security | ||
# @TravisEz13 @leeholmes @SteveL-MSFT @PaulHigin @chunqingchen | ||
# @TravisEz13 @leeholmes @PaulHigin @chunqingchen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove leeholmes, he isn't generally available so Paul, Travis, or I will pull him in when needed. Remove chunqing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#Resolved
.github/CODEOWNERS
Outdated
demos/ @joeyaiello @SteveL-MSFT @HemantMahawar | ||
|
||
# Area: DSC | ||
src/System.Management.Automation/DscSupport @TravisEz13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add dantraMSFT to DSC as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
Travis CI temporary failed - I restarted it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just realized that this cause Jim, Travis and Aditya to be dragged into almost every PR review. |
Rules later in the file are supposed to override previous rules. Let's see how it actually works before we change it. |
But looking at least one PR it looks like it takes the aggregate of what it finds from the rules. Do you want me to submit a PR removing the area-test rule? |
add codeowner file to automatically assign reviewers and to describe who owns areas.