Update nano server insider for new bulid #4555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
reviewed
Aug 11, 2017
| # Copy Powershell from the installer containter | ||
| ENV ProgramFiles C:\Program Files | ||
| COPY --from=installer-env ["\\PowerShell\\", "$ProgramFiles\\PowerShell"] | ||
|
|
||
| # Persist %PSCORE% ENV variable for user convenience | ||
| ENV PSCORE="$ProgramFiles\PowerShell\PowerShell.exe" | ||
|
|
||
| # setx /M fails on nanoserver-insider, setting the user path | ||
| # Set the path | ||
| RUN setx PATH "%PATH%;%ProgramFiles%\PowerShell" |
There was a problem hiding this comment.
Just curious, setx /M is not necessary on nanoserver because it's a single user OS, correct?
There was a problem hiding this comment.
correct, they fixed the container to use the per user path.
daxian-dbw
reviewed
Aug 11, 2017
| RUN setx PATH "%PATH%;%ProgramFiles%\PowerShell" | ||
|
|
||
| CMD ["C:\\Program Files\\PowerShell\\PowerShell.exe"] |
There was a problem hiding this comment.
In docker/README.md:
Due to an issue with the container not picking up the path, you must specify the path when running a command on the command line.
Looks like the PATH issue has been fixed, so the document should be updated.
There was a problem hiding this comment.
I added a note that it will be fixed soon. I have to setup a build machine matching the exact build of the container, which might take me some time.
daxian-dbw
approved these changes
Aug 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, Address #4310