8000 Add an additional acceptance test for the PowerShellGet module by bmanikm · Pull Request #4531 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add an additional acceptance test for the PowerShellGet module #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2017
Merged

Add an additional acceptance test for the PowerShellGet module #4531

merged 2 commits into from
Aug 10, 2017

Conversation

bmanikm
Copy link
Contributor
@bmanikm bmanikm commented Aug 8, 2017
  • This acceptance test will ensure that there are no regressions in PowerShell build w.r.t. to adding a .NET type in PowerShellGet module.

Krishna-Vutukuri
Krishna-Vutukuri reviewed Aug 9, 2017
View reviewed changes
test/powershell/Modules/PowerShellGet/PowerShellGet.Tests.ps1
@@ -90,7 +90,7 @@ function Initialize

function Remove-InstalledModules
{
Get-InstalledModule -Name $ContosoServer -AllVersions -ErrorAction SilentlyContinue | Uninstall-Module -Force
Get-InstalledModule -Name $ContosoServer -AllVersions -ErrorAction SilentlyContinue | PowerShellGet\Uninstall-Module -Force
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might throw right? Do you want to ignore those errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be any errors in uninstalling the test module, otherwise other test cases will fail.

@jianyunt
Copy link
Contributor
jianyunt commented Aug 9, 2017

:shipit:

@adityapatwardhan adityapatwardhan merged commit 0bfee35 into PowerShell:master Aug 10, 2017
@bmanikm bmanikm deleted the AddPowerShellGetAcceptanceTest branch August 11, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krishna-Vutukuri Krishna-Vutukuri Krishna-Vutukuri left review comments

@vors vors Awaiting requested review from vors

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@jianyunt jianyunt Awaiting requested review from jianyunt

Assignees

@adityapatwardhan adityapatwardhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bmanikm @jianyunt @Krishna-Vutukuri @msftclas @adityapatwardhan
0