10000 Remove last-modified from headers from travis CI script by JamesWTruher · Pull Request #4522 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Remove last-modified from headers from travis CI script #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tools/travis.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ function Set-DailyBuildBadge
$headers = @{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$now is not used any more. We should remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still being used in x-ms-date

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still used - two lines higher

"x-ms-date" = $now
"cache-control" = "no-cache"
"last-modified" = $now
"x-ms-blob-type" = "BlockBlob"
"x-ms-version" = "$headerDate"
}
Expand Down Expand Up @@ -220,4 +219,4 @@ else
}

Start-PSxUnit
}
}
0