8000 Fix Tests from #4479 by markekraus · Pull Request #4512 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix Tests from #4479 #4512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2017
Merged

Fix Tests from #4479 #4512

merged 2 commits into from
Aug 7, 2017

Conversation

markekraus
Copy link
Contributor

My Bad... the tests I had in #4479 were failing in the nightly. This fixes them and now they now pass and fail for the right reasons.

@msftclas
Copy link
msftclas commented Aug 6, 2017

@markekraus,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@adityapatwardhan
Copy link
Member

@markekraus Thanks for fixing the tests. Can you run 'Feature' tests to validate that all the required tests are executed.

The documentation for executing additional tests is at: https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/testing-guidelines.md

Look for the section titled 'Requesting additional tests for a PR'

@adityapatwardhan
Copy link
Member

@markekraus I have pushed an empty commit to execute the feature tests.

@markekraus
Copy link
Contributor Author

@adityapatwardhan Thank you. I will make sure to do this in the future.

@markekraus
Copy link
Contributor Author
markekraus commented Aug 7, 2017 •
edited
Loading

@adityapatwardhan The tests pass now.

The Travis CI failure appears to be unrelated.

@adityapatwardhan
Copy link
Member

@markekraus Restarted the tests on Travis CI.

@markekraus
Copy link
Contributor Author

@adityapatwardhan All Travis CI Tests passing now as well

@adityapatwardhan
Copy link
Member

@daxian-dbw Can you have a quick look? This fixes the daily build failure.

@adityapatwardhan adityapatwardhan merged commit e4060ab into PowerShell:master Aug 7, 2017
@adityapatwardhan
Copy link
Member

@markekraus Thanks for fixing the tests.

@markekraus markekraus mentioned this pull request Aug 8, 2017
Merged
@markekraus markekraus deleted the WebCmdletTestFix branch August 25, 2017 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees

@adityapatwardhan adityapatwardhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markekraus @msftclas @adityapatwardhan @daxian-dbw
0