Add Missing Assemblies to TPA List for Pwrshplugin.dll #4502
Conversation
| # during compilation. We work around the problem by force-including the | ||
| # contents of the environment variable before it gets corrupted. | ||
| # | ||
| target_include_directories(pwrshcommon PUBLIC $ENV{INCLUDE}) |
There was a problem hiding this comment.
I assume adding this would still work on a machine with VS15 installed only, right?
There was a problem hiding this comment.
That is the scenario where I ran it. My system has VS 2015 and VS 2017 installed side-by-side. I have not verified it on a system that only has VS 2017. As long as vcvarsall.bat generates the correct INCLUDE environment variable, it should work though.
Additional search paths will not cause a working instance to fail, so it is a lower risk change.
There was a problem hiding this comment.
I have not verified it on a system that only has VS 2017.
I'm not worried about a system that only has VS 2017, but a system that only has VS 2015. Our current release build pipeline in VSTS only installs VS 2015. I want to make sure we don't break there.
There was a problem hiding this comment.
OK. I checked out this PR and verified that it builds fine with VS 2015 installed only and the generated plugin binary works.
This PR updates the TPA list for pwrshplugin.dll to reflect the recent additions to the DLL. It also adds support for VS 2017 compilation by adding a work-around for and include path that gets corrupted by VS 2017.