Fix unblock read only file #4395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iSazonov what is the error message the user sees now? |
|
MSDN says that Unblock-File : Access is denied
At line:1 char:1
+ Unblock-File -Path $Testpath
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (:) [Unblock-File], Win32Exception
+ FullyQualifiedErrorId : System.ComponentModel.Win32Exception,Microsoft.PowerShell.Commands.UnblockFileCommand |
lzybkr
reviewed
Aug 5, 2017
| if (!NativeMethods.DeleteFile(resultPath)) | ||
| { | ||
| int error = Marshal.GetLastWin32Error(); | ||
| throw new Win32Exception(error); |
There was a problem hiding this comment.
Shouldn't this be a non-terminating error? The following should behave similarly:
dir | Unblock-File
dir | Remove-ItemIn the Remove-Item case, a read only file reports an error, but all other files are deleted.
There was a problem hiding this comment.
Good catch!
AlternateDataStreamUtilities uses the pattern. So maybe add try-catch in Unblock-File cmdlet file?
|
@lzybkr @SteveL-MSFT Please continue the code review. |
A commit has been added to the review
lzybkr
approved these changes
Aug 11, 2017
SteveL-MSFT
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new non-terminating error
Fix #4390.
Problem
If a file is read only it is skipping silently.
Fix
Analize GetLastError() and throw if a file stream hasn't been removed.
First commit only refactor tests to use
ShouldBeErrorId.