Give error instead of crashing if WSMan client lib not available #4387

SteveL-MSFT · 2017-07-28T23:12:36Z

Affects NanoServer Insider build where WinRM is not available. Currently if user tries invoke-command, powershell crashes.

Validated using:

PS> docker run -it -v C:\users\slee\repos\PowerShell\src\powershell-wincore\bin\Debug\netcoreapp2.0\win10-x64\publish:c:\powershell microsoft/nanoserver-insider-powershell
PS> c:\powershell\powershell
PS> invoke-command -computer . -command { "hello" }

invoke-command : WSMan client library is not installed
At line:1 char:1
+ invoke-command -ComputerName . -Command { "hello" }
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ResourceUnavailable: (:) [Invoke-Command], PSRemotingTransportException
    + FullyQualifiedErrorId : System.Management.Automation.Remoting.PSRemotingDataStructureException,Microsoft.PowerSh
   ell.Commands.InvokeCommandCommand

Fix #4383

…of crashing

iSazonov · 2017-07-31T05:10:25Z

src/System.Management.Automation/resources/RemotingErrorIdStrings.resx

    <value>The SSH transport process has abruptly terminated causing this remote session to break.</value>
  </data>
+  <data name="WSManClientDllNotAvailable" xml:space="preserve">
+    <value>WSMan client library is not installed</value>


Typo - skipped a point at end.
And may be add short recomendation to user how resolve the problem?

Agreed. It sounds like this only affects Nano. So maybe something like "WSMan client library is not installed. This parameter set requires WSMan for PowerShell remoting commands such as Invoke-Command, New-PSSession, Enter-PSSession." The problem is that SSH remoting may be available if SSH client is installed. But I don't know if that is a likely scenario.

cc @joeyaiello to review error message

This currently only affects Nano, but it's not something easily fixed on Nano. Basically user need to start with a different Nano image that includes WinRM. I don't think we want to put too much detail in the message as it could create more confusion particularly as @PaulHigin pointed out PSRP/SSH could still work if they have ssh.exe (which is probably more likely in the future once OpenSSH port is further along)cc @joeyaiello to review error message

This currently only affects Nano, but it's not something easily fixed on Nano. Basically user need to start with a different Nano image that includes WinRM. I don't think we want to put too much detail in the message as it could create more confusion particularly as @PaulHigin pointed out PSRP/SSH could still work if they have ssh.exe (which is probably more likely in the future once OpenSSH port is further along)

I see. Yes I agree that the error message is fine as is.

How about "This parameter set requires WSMan, and no WSMan client library is available. WSMan is either not installed or unavailable for this platform. It might also be possible to use SSH-based remoting instead."

@joeyaiello I'm fine with everything except the last sentence as SSH may or may not be installed. I don't think we need to go to that much detail at this point. Ideally, we should just tell the user run Enable-PSRemoting and magic happens, but that's not anytime soon.

PaulHigin · 2017-07-31T15:50:52Z

src/System.Management.Automation/resources/RemotingErrorIdStrings.resx

    <value>The SSH transport process has abruptly terminated causing this remote session to break.</value>
  </data>
+  <data name="WSManClientDllNotAvailable" xml:space="preserve">
+    <value>WSMan client library is not installed</value>


Agreed. It sounds like this only affects Nano. So maybe something like "WSMan client library is not installed. This parameter set requires WSMan for PowerShell remoting commands such as Invoke-Command, New-PSSession, Enter-PSSession." The problem is that SSH remoting may be available if SSH client is installed. But I don't know if that is a likely scenario.

PaulHigin

LGTM

daxian-dbw · 2017-07-31T17:48:00Z

src/System.Management.Automation/engine/remoting/fanin/WSManTransportManager.cs

+                catch (DllNotFoundException)
+                {
+                    throw new PSRemotingTransportException(
+                        StringUtil.Format(RemotingErrorIdStrings.WSManClientDllNotAvailable));


StringUtil.Format(..) is unnecessary as no arguments is required for the error message.

will fix. lazy cut and paste :)

joeyaiello

Fine on the SSH pushback, good enough for me.

SteveL-MSFT assigned daxian-dbw Jul 28, 2017

SteveL-MSFT requested a review from PaulHigin July 28, 2017 23:12

msftclas added the cla-not-required label Jul 28, 2017

Give better error when WSMan client library is not available instead …

672431e

…of crashing

SteveL-MSFT force-pushed the invoke-command branch from 8e4467e to 672431e Compare July 28, 2017 23:14

iSazonov reviewed Jul 31, 2017

View reviewed changes

PaulHigin suggested changes Jul 31, 2017

View reviewed changes

PaulHigin approved these changes Jul 31, 2017

View reviewed changes

daxian-dbw reviewed Jul 31, 2017

View reviewed changes

updated error message based on feedback giving a bit more detail

981bdb0

SteveL-MSFT force-pushed the invoke-command branch from 3e89217 to 981bdb0 Compare July 31, 2017 19:47

joeyaiello approved these changes Jul 31, 2017

View reviewed changes

daxian-dbw merged commit cf9f8c8 into PowerShell:master Jul 31, 2017

SteveL-MSFT deleted the invoke-command branch August 1, 2017 00:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Give error instead of crashing if WSMan client lib not available #4387

Give error instead of crashing if WSMan client lib not available #4387

Give error instead of crashing if WSMan client lib not available #4387

Give error instead of crashing if WSMan client lib not available #4387

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment