Add test coverage for Registry #4354

jeffbi · 2017-07-26T22:34:09Z

Addresses parts of #4148

Add coverage for Get-Item, Get-ChildItem, Set-Item, and Clear-Item

Add coverage for Get-Item, Get-ChildItem, Set-Item, and Clear-Item

SteveL-MSFT · 2017-07-27T21:08:22Z

Missing tests:

invalid hive root
validate -whatif works for set-item and clear-item
attempt accessing path you don't have access to

jeffbi · 2017-07-28T18:58:20Z

@SteveL-MSFT These test run with the tag RequireAdminOnWindows. Is there a Registry path that admin would not have access to?

SteveL-MSFT · 2017-07-28T20:01:40Z

@jeffbi try HKLM:\sam

adityapatwardhan

Minor comment

adityapatwardhan · 2017-07-28T20:52:05Z

test/powershell/Modules/Microsoft.PowerShell.Management/Registry.Tests.ps1

@@ -125,6 +169,22 @@ Describe "Basic Registry Provider Tests" -Tags @("CI", "RequireAdminOnWindows")
            $property."$testPropertyName" | Should Be 0
        }

+        It "Verity Clear-Item" {


Typo Verity->Verify

SteveL-MSFT · 2017-07-28T20:59:04Z

test/powershell/Modules/Microsoft.PowerShell.Management/Registry.Tests.ps1

+            $key.Property.Length | Should BeExactly 0
+        }
+
+        It "Verity Clear-Item with -WhatIf" {


Typo here has well Verify

jeffbi · 2017-07-28T22:15:52Z

Typos fixed.

The Travis failure seems to be in a test for Invoke-Item.

SteveL-MSFT · 2017-07-28T22:17:30Z

@jeffbi I have a PR to change the invoke-item tests to Feature as they shouldn't be CI anyways, I'll restart the Mac job, there's a chance it'll pass as it's a timing issue

SteveL-MSFT

LGTM

Add test coverage for Registry (#4148)

cec7f3f

Add coverage for Get-Item, Get-ChildItem, Set-Item, and Clear-Item

msftclas added the cla-already-signed label Jul 26, 2017

daxian-dbw assigned adityapatwardhan Jul 28, 2017

Add more tests per code review.

307d107

Add test for accessing inaccessible path, per code review.

6f28212

adityapatwardhan requested changes Jul 28, 2017

View reviewed changes

SteveL-MSFT requested changes Jul 28, 2017

View reviewed changes

Fix typos.

a946fc5

SteveL-MSFT approved these changes Jul 28, 2017

View reviewed changes

adityapatwardhan approved these changes Jul 28, 2017

View reviewed changes

adityapatwardhan merged commit 19fcd43 into PowerShell:master Aug 2, 2017

jeffbi deleted the tests-4148-registry branch August 2, 2017 18:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test coverage for Registry #4354

Add test coverage for Registry #4354

Add test coverage for Registry #4354

Add test coverage for Registry #4354

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment