8000 Increase test coverage for Rename-Item and Move-Item by jeffbi · Pull Request #4329 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Increase test coverage for Rename-Item and Move-Item #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 2, 2017
Merged

Increase test coverage for Rename-Item and Move-Item #4329

merged 6 commits into from
Aug 2, 2017

Conversation

jeffbi
Copy link
Contributor
@jeffbi jeffbi commented Jul 24, 2017

Addresses parts of #4148.

dantraMSFT
dantraMSFT suggested changes Jul 25, 2017
View reviewed changes
Copy link
Contributor
@dantraMSFT dantraMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest using -ErrorAction Stop for the operations that you expect to succeed. It will be clearer than diagnosing why the Should statement failed.

@jeffbi
Copy link
Contributor Author
jeffbi commented Jul 25, 2017

Fixed.

adityapatwardhan
adityapatwardhan requested changes Jul 28, 2017
View reviewed changes
Copy link
Member
@adityapatwardhan adityapatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment.

test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1 Outdated
"$destDir/$testDir/$testFile" | Should Exist
}

It "Verity Move-Item will not move to an existing file" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in Verity -> Verify

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

SteveL-MSFT
SteveL-MSFT requested changes Jul 28, 2017
View reviewed changes
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1 Outdated
$testDir | Should Exist
}

It "Verify Move-Item as substitue for Rename-Item" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: substitute

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@SteveL-MSFT
Copy link
Member

Add test for Access Denied

@jeffbi
Copy link
Contributor Author
jeffbi commented Aug 1, 2017

Added tests for access-denied. @SteveL-MSFT thanks for the pointer.

SteveL-MSFT
SteveL-MSFT approved these changes Aug 1, 2017
View reviewed changes
Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan adityapatwardhan merged commit 8f9aed8 into PowerShell:master Aug 2, 2017
@jeffbi jeffbi deleted the tests-4148 branch August 2, 2017 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@dantraMSFT dantraMSFT dantraMSFT approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

Assignees

@adityapatwardhan adityapatwardhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeffbi @SteveL-MSFT @dantraMSFT @adityapatwardhan @msftclas
0