8000 Small grammar change to pull requests guide by zjalexander · Pull Request #4322 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Small grammar change to pull requests guide #4322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Conversation

zjalexander
Copy link
Contributor

him -> them, which is consistent with usage above.

him -> them, which is consistent with usage above.
@msftclas
Copy link

@zjalexander,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Copy link
Member
@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Them is more appropriate than him but perhaps we should adopt a writing style to guide this. Here is a link to guidance on resolving this for APA Style

@TravisEz13
Copy link
Member
TravisEz13 commented Jul 24, 2017

Please fix PR title
Please use the present tense, imperative style for commit messages and title per Contribution Guide
Suggestion Remove gender specific language in PR process

@zjalexander zjalexander changed the title style change Small grammar change to pull requests guide Jul 24, 2017
@TravisEz13 TravisEz13 merged commit 7d5367a into master Aug 4, 2017
@TravisEz13 TravisEz13 deleted the zjalexander-patch-1 branch August 4, 2017 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0