8000 Enable MSI upgrades rather than side-by-side install by SteveL-MSFT · Pull Request #4259 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Enable MSI upgrades rather than side-by-side install #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2017

Conversation

SteveL-MSFT
Copy link
Member

MSI only works against A.B.C type version strings. So to enable beta.X to beta.X+1 upgrades, we have to use the AllowSameVersionUpgrades as they are all effectively 6.0.0 from MSI point of view.

Note that to get Wix toolset working on Win10, you may have to pass -sval to light.exe.

Fix #3946

@SteveL-MSFT SteveL-MSFT requested a review from raghushantha July 14, 2017 21:29
@SteveL-MSFT SteveL-MSFT changed the title Enable upgrades rather than side-by-side install Enable MSI upgrades rather than side-by-side install Jul 14, 2017
@raghushantha
Copy link
Member

@SteveL-MSFT Changes look good. The only thing is to watch out for is that the 'ProductGuid' needs to be the same if you need upgrade to be supported.

For major version changes, ProductGuid can be changed

@SteveL-MSFT
Copy link
Member Author

@raghushantha currently, Start-PSPackage has a default static ProductGuid so we should be good there.

@TravisEz13 TravisEz13 merged commit 0627409 into PowerShell:master Jul 17, 2017
@SteveL-MSFT SteveL-MSFT deleted the msi-upgrade branch July 18, 2017 04:35
@ChristophB125
Copy link

@SteveL-MSFT or @raghushantha It's great to have upgradability support but does this mean that we lose the ability of having multiple version installed side-by-side? We use older versions of PowerShell Core in our CI system (that is locked down and therefore not updated unless needed) and I always found it handy being able to repro on my local machine using the same version that is being used in CI in order to replicate the exact same behaviour.

@SteveL-MSFT
Copy link
Member Author

@ChristophB125 You can still have side-by-side by downloading the zip and extracting the contents in a secure location (this will always be supported).

@ChristophB125
Copy link

Thanks for the info. The self contained version in a zip file should be sufficient for our use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0