Remove UTC and SQM telemetry code #4190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested changes
Jul 7, 2017
| @@ -44,8 +46,12 @@ internal sealed partial class ConsoleHost | ||
| : | ||
| PSHost, | ||
| IDisposable, | ||
| #if LEGACYTELEMETRY | ||
| IHostSupportsInteractiveSession, | ||
| IHostProvidesTelemetryData |
There was a problem hiding this comment.
Can you rearrange the order to avoid the #else?
This is done via `#if LEGACYTELEMETRY` to make it easier to bring back at a later time
remove the #else so it's a little cleaner
ee63f52 to
f91ec0b
Compare
SteveL-MSFT
requested changes
Jul 13, 2017
| @@ -44,8 +46,12 @@ internal sealed partial class ConsoleHost | |||
| : | |||
| PSHost, | |||
| IDisposable, | |||
| IHostSupportsInteractiveSession | |||
There was a problem hiding this comment.
I think this should be:
#if LEGACYTELEMETRY
IHostProvidesTelemetryData,
#endif
IHostSupportsInteractiveSession|
The old telemetry implementation are still kept in code base (PSTelemetryMethods.cs, PSTelemetryWrapper.cs). Shall we delete them in this PR? |
|
@daxian-dbw current thinking is to keep it for now. We'll likely add more telemetry in 6.1.0 and we can see what we can reuse from the old telemetry and clean up the code completely at that time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #3807
The historical telemetry code uses WindowsUTC which is not applicable to non-Windows platforms and is superseded by our ApplicationInsight telemetry.
#if LEGACYTELEMETRYwas used to make it easier to track when we add our next round of telemetry.Change should not be visible to the user, unless they were inspecting the eventlog looking for it. Any SQM telemetry appears to have been disabled in June 2016.