Minimize writing ANSI escape sequences in PSReadline #4110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of changing Console.*groundColor on every character, only set the color when the color changes - this avoids writing out ANSI escape sequences after every character. Fixes PowerShell#4075
SteveL-MSFT
reviewed
Jun 26, 2017
| Console.BackgroundColor = buffer[i].BackgroundColor; | ||
| var nextForegroundColor = buffer[i].ForegroundColor; | ||
| var nextBackgroundColor = buffer[i].BackgroundColor; | ||
| if (lastForegroundColor != nextForegroundColor) |
There was a problem hiding this comment.
Small nitpick, but it seems that if (nextForegroundColor != lastForegroundColor) is slightly more correct improving readability
| { | ||
| Console.ForegroundColor = lastForegroundColor = nextForegroundColor; | ||
| } | ||
| if (lastBackgroundColor != nextBackgroundColor) |
|
|
||
| Console.Write(buffer[i].UnicodeChar); | ||
| } | ||
|
|
||
| Console.BackgroundColor = backgroundColor; | ||
| Console.ForegroundColor = foregroundColor; | ||
| if (backgroundColor != lastBackgroundColor) |
There was a problem hiding this comment.
Pretty much everywhere else you have foreground first, then background. Another nitpick, but I would reorder these two if statements
SteveL-MSFT
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of changing Console.*groundColor on every character, only set
the color when the color changes - this avoids writing out ANSI escape
sequences after every character.
Fixes #4075