Remove ClrVersion property from $PSVersionTable #4027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… end users should not be using that value to determine compatibility. Recommendation from dotnet team is to remove that property.
iSazonov
reviewed
Jun 16, 2017
There was a problem hiding this comment.
I believe we should remove internal static Version CLRVersion and internal const string PSCLRVersionName
|
@iSazonov will remove those |
iSazon
8000
ov
approved these changes
Jun 16, 2017
|
LGTM. |
|
@mirichmo can you merge? |
mirichmo
reviewed
Jun 19, 2017
| @@ -162,14 +160,6 @@ internal static string GitCommitId | |||
| } | |||
| } | |||
|
|
|||
| internal static Version CLRVersion | |||
There was a problem hiding this comment.
What is our stance on removing FullCLR compatibility of the code? If we are dropping that requirement and only focusing on CoreCLR, then you should remove PSCLRVersionName from line 77 as well.
There was a problem hiding this comment.
Removed it since we removed the other members anyways. After beta.3 goes out, I intend to revisit the discussion about removing FullCLR code.
mirichmo
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ClrVersion property of $PSVersionTable is not useful with CoreCLR and end users should not be using
that value to determine compatibility. Recommendation from dotnet team is to remove that property.
Fix #1395