8000 Make 'Start-PSBuild' and 'Start-PSPackage' accept a release tag argument by daxian-dbw · Pull Request #3921 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Make 'Start-PSBuild' and 'Start-PSPackage' accept a release tag argument #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 5, 2017
Merged

Make 'Start-PSBuild' and 'Start-PSPackage' accept a release tag argument #3921

merged 4 commits into from
Jun 5, 2017

Conversation

daxian-dbw
Copy link
Member
@daxian-dbw daxian-dbw commented Jun 2, 2017 •
edited
Loading

Partially fix #3909

Issue Summary

Currently a release build depends on the release tag to be pushed. We need to break this dependency, so that creating the release tag can be made the last step of a release -- do it only if all preparation of the release is done.

Fix

Add a new parameter -ReleaseTag to Start-PSBuild and Start-PSPackage to allow a release tag to be passed in. When the release tag is specified at the command line, it will override the git commit id retrieved from git describe.

Example

# Build for v6.0.0-beta.3 release
Start-PSBuild -Clean -CrossGen -PSModuleRestore -ReleaseTag v6.0.0-beta.3

# Create package for v6.0.0-beta.3 release
Start-PSPackage -ReleaseTag v6.0.0-beta.3

Follow-up work

Our VSO build script need to update to somehow accept a release tag value and pass it along when it's specified.

@daxian-dbw daxian-dbw request 8000 ed a review from TravisEz13 June 2, 2017 17:07
lzybkr
lzybkr reviewed Jun 2, 2017
View reviewed changes
build.psm1 Outdated
[string]$Version,

[Parameter(ParameterSetName = "ReleaseTag")]
[ValidatePattern("^v\d+\.\d+\.\d+-\w+\.\d+$")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -\w+\.\d+ part should be optional - an official release won't have that part I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Wil update the reg expression.

lzybkr
lzybkr reviewed Jun 2, 2017
View reviewed changes
build.psm1 Outdated

copy files FROM .\src\monad (old location of submodule) TO src/<project> folders
#>
function Copy-MappedFiles {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this belong in a distinct change for another PR? Maybe also removing the json files and other functions like Get-Mappings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, Actually @vors submitted a PR to do so: #3407. Maybe we need committee's approval to go ahead with that PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such clean-ups will help us to move to MSBuild.

@daxian-dbw daxian-dbw merged commit 299a8ab into PowerShell:master Jun 5, 2017
@daxian-dbw daxian-dbw deleted the build-script branch June 5, 2017 17:21
@daxian-dbw daxian-dbw mentioned this pull request Jun 6, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzybkr lzybkr lz 6732 ybkr left review comments

@iSazonov iSazonov iSazonov left review comments

@TravisEz13 TravisEz13 TravisEz13 approved these changes

Assignees

@TravisEz13 TravisEz13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We should be able to complete all tasks for a release in a branch before creating the release tag
5 participants
@daxian-dbw @lzybkr @TravisEz13 @iSazonov @msftclas
0