Add version to PowerShell banner #3916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vors
suggested changes
Jun 3, 2017
| </data> | ||
| <data name="ShellBannerNonWindowsPowerShell" xml:space="preserve"> | ||
| <value>PowerShell | ||
| Copyright (C) Microsoft Corporation. All rights reserved.</value> | ||
| Copyright (C) Microsoft Corporation. All rights reserved. | ||
| Version: {0}</value> |
There was a problem hiding this comment.
I think the version proposed by @SteveL-MSFT originally reads nicer:
PowerShell {0}
Copyright (C) Microsoft Corporation. All rights reserved.
For example, here is how python banner looks like
Python 2.7.10 (default, Oct 18 2015, 00:31:39)
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-700.0.72)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
There was a problem hiding this comment.
I think it doesn't look elegant :-) but fixed.
|
@vors Can you approve and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3895
Motivation
Since we support side-by-side, it makes it easier to see which PowerShell version you started rather than checking $psversiontable or $pshome.
Fix
Add "GitCommitId" to PowerShell banner.
Follow-up work
Based on #3690 later we will change a GitCommitId format.