8000 Removed import-module $helperModule as it is not needed. by adityapatwardhan · Pull Request #3814 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Removed import-module $helperModule as it is not needed. #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2017

Conversation

adityapatwardhan
Copy link
Member

$helperModule is not defined anymore after refactoring changes. Import-Module is not necessary, hence removed.
This is was not caught by CI as these are Feature tests.
This caused the daily build to be broken.

Related to changes done in: #3456

$helperModule is not defined anymore after refactoring changes. Import-Module is not necessary, hence removed.
This is was not caught by CI as these are Feature tests.
@adityapatwardhan
Copy link
Member Author

@daxian-dbw Can you have a look? This is breaking daily build.

Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator
@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adityapatwardhan
Copy link
Member Author

@PowerShell/powershell-maintainers This is ready to merge. This fixes the daily build.

@daxian-dbw daxian-dbw merged commit f201782 into PowerShell:master May 19, 2017
@adityapatwardhan adityapatwardhan deleted the FixDailyBuild branch May 19, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0