PSVersionTable should have entry for OS and Platform #3654
Conversation
|
@JamesWTruher - Please review this change as well |
| s_psVersionTable["CLRVersion"] = null; | ||
| #else | ||
| s_psVersionTable["CLRVersion"] = Environment.Version; | ||
| s_psVersionTable["OS"] = Environment.OSVersion; |
There was a problem hiding this comment.
Shouldn't this use .ToString() as OSVersion is an object?
|
@SteveL-MSFT Thank you, your comment has been resolved. |
| else | ||
| { | ||
| $OSDescription = [String][System.Environment]::OSVersion | ||
| [String]$PSVersionTable["OS"] | Should Be [System.Environment]::OSVersion |
There was a problem hiding this comment.
Part of me thinks we shouldn't make any changes for FullCLR, but if we're making the change it seems this line would fail as the right hand side should use ToString()
|
@SteveL-MSFT comment resolved. |
| @@ -1,6 +1,6 @@ | |||
| Describe "PSVersionTable" -Tags "CI" { | |||
| It "Should have version table entries" { | |||
| $PSVersionTable.Count | Should Be 9 | |||
| $PSVersionTable.Count | Should Be 11 | |||
There was a problem hiding this comment.
Please fix the indentation within this file. It looks like you may have added tab characters instead of spaces. My comment applies to all changes made within this file.
|
@mirichmo I have tried to modify all the tab previous file contains into space. |
|
Thanks. I'll merge it once it passes CI. I restarted since Travis failed with a possible unrelated issue. |
This is to resolve #1635
$PSVersionTable.OS now outputs [Runtime.InteropServices.RuntimeInformation]::OSDescription ([System.Environment]::OSVersion if not under coreclr)
$PSVersionTable.Platform outputs [System.Environment]::OSVersion.Platform