Fixing #3624 - Readline crash with @{<tab> #3626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
reviewed
Apr 24, 2017
| @@ -442,6 +442,14 @@ internal List<CompletionResult> GetResultHelper(CompletionContext completionCont | |||
| result = GetResultForEnumPropertyValueOfDSCResource(completionContext, string.Empty, ref replacementIndex, ref replacementLength, out unused); | |||
| } | |||
| break; | |||
| case TokenKind.AtCurly: | |||
| // Handle scenarios such as Sort-Object @{<tab> || gci | Format-Table @{ | |||
There was a problem hiding this comment.
Sort-Object @{ || gci | Format-Table @{
minor comment: can we change this to 'Sort-Object @{<tab>' or 'gci | Format-Table @{'? I think it's more readable.
daxian-dbw
reviewed
Apr 24, 2017
| @@ -54,4 +54,13 @@ Describe "Tab completion bug fix" -Tags "CI" { | |||
| $result.CompletionMatches[1].CompletionText | Should Be $DatetimeProperties[1].Name # DateTime | |||
| } | |||
| } | |||
|
|
|||
| It "Issue#3628 - 'Sort-Object @{<tab> should work" { | |||
There was a problem hiding this comment.
'Sort-Object @{ should work
Minor comment: did you miss a single quote? :)
Adressing review comments
|
@daxian-dbw Thx for the review. Issues addressed. |
|
LGTM. @powercode I added link on Issue in description. The Issue will be auto closed after merge. And it is useful to see a link to the PR in the Issue. |
|
@iSazonov I thought the number in the title did so, but apparently I was incorrect :) |
daxian-dbw
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3624