8000 Use IntPtr(-1) for INVALID_HANDLE_VALUE instead of IntPtr.Zero by 0xfeeddeadbeef · Pull Request #3544 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Use IntPtr(-1) for INVALID_HANDLE_VALUE instead of IntPtr.Zero #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sig 8000 n up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2017
Merged

Use IntPtr(-1) for INVALID_HANDLE_VALUE instead of IntPtr.Zero #3544

merged 1 commit into from
Apr 14, 2017

Conversation

0xfeeddeadbeef
Copy link
Contributor
@0xfeeddeadbeef 0xfeeddeadbeef commented Apr 12, 2017 •
edited
Loading
  • Fix incorrect handling of GetCurrentProcess() API return value in IsWow64() function (MainEntry.cpp)
  • Remove unused INVALID_HANDLE_VALUE field from ProcessNativeMethods class (Process.cs)

Fixes #3540

@0xfeeddeadbeef
Use IntPtr(-1) for INVALID_HANDLE_VALUE instead of IntPtr.Zero
3238535 
- Fix incorrect handling of GetCurrentProcess() API return value in
  IsWow64() function (MainEntry.cpp)
- Remove unused INVALID_HANDLE_VALUE field from ProcessNativeMethods
  class (Process.cs)

Fixes #3540
SteveL-MSFT
SteveL-MSFT approved these changes Apr 12, 2017
View reviewed changes
Copy link
Member
@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov
Copy link
Collaborator

LGTM.

@0xfeeddeadbeef Thanks! We will be glad to see you again with new contributions.

@daxian-dbw daxian-dbw merged commit 47ec6b2 into PowerShell:master Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees

@TravisEz13 TravisEz13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0xfeeddeadbeef @iSazonov @SteveL-MSFT @daxian-dbw @msftclas @TravisEz13
0