Add tab completion for Select-Object -ExcludeProperty -ExpandProperty #3443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzybkr
reviewed
Mar 28, 2017
| @@ -35,4 +35,18 @@ Describe "Tab completion bug fix" -Tags "CI" { | |||
| $result.CompletionMatches[1].CompletionText | Should Be "-NoClobber" | |||
| $result.CompletionMatches[2].CompletionText | Should Be "-NoOverwrite" | |||
| } | |||
| It "Issue#3416 - 'Select-Object -ExcludeProperty <tab>' should work" { | |||
There was a problem hiding this comment.
This file is the only one where we have issues numbers in the output of the test - I'm not sure how useful that is though.
I find git blame sufficient for tracking back to an issue, but comments are also sufficient. In the output though - it's just clutter in my opinion.
There was a problem hiding this comment.
I already have this issue opened to eventually address this: #3369
lzybkr
reviewed
Mar 28, 2017
| It "Issue#3416 - 'Select-Object -ExcludeProperty <tab>' should work" { | ||
| $cmd = "Get-Date | Select-Object -ExcludeProperty " | ||
| $result = TabExpansion2 -inputScript $cmd -cursorColumn $cmd.Length | ||
| $result.CompletionMatches.Count | Should Be 15 |
There was a problem hiding this comment.
This could be a fragile test, e.g. if a new version of .Net adds a property.
A more reliable test would look for specific results and not care about ordering.
lzybkr
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3416