8000 fixed drifting of progress bar on Unix by SteveL-MSFT · Pull Request #3289 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

fixed drifting of progress bar on Unix #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2017
Merged

fixed drifting of progress bar on Unix #3289

merged 1 commit into from
Mar 11, 2017

Conversation

SteveL-MSFT
Copy link
Member

progress bar was incorrectly setting the original x position which causes the progress to slowly move to the right in certain cases

addresses #3202

need some suggestions on how to add a test for this

@SteveL-MSFT
progress bar was incorrectly setting the original x position which ca…
8ddd89c 
…uses the progress to slowly move to the right in certain cases

addresses PowerShell#3202
@SteveL-MSFT SteveL-MSFT requested a review from lzybkr March 9, 2017 22:20
@lzybkr lzybkr self-assigned this Mar 9, 2017
lzybkr
lzybkr approved these changes Mar 9, 2017
View reviewed changes
Copy link
Contributor
@lzybkr lzybkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's worth adding a test for this.

The code doesn't change frequently, and it's difficult to test.

@SteveL-MSFT
Copy link
Member Author

@lzybkr it's also something easily noticed by people using PowerShell if it's not working :)

@daxian-dbw daxian-dbw merged commit 9c40d29 into PowerShell:master Mar 11, 2017
@SteveL-MSFT SteveL-MSFT deleted the progressbar branch March 21, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzybkr lzybkr lzybkr approved these changes

Assignees

@lzybkr lzybkr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SteveL-MSFT @lzybkr @daxian-dbw @msftclas
0