-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Remove System.Array type data #3231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove System.Array type data #3231
Conversation
@PetSerAl, |
#3230 is opened to track other |
@@ -1,19 +1,23 @@ | |||
Describe "TestData cmdlets" -Tags "CI" { | |||
Context "Get-TypeData" { | |||
It "System.Array" { | |||
(Get-TypeData System.Array).TypeName | Should Be System.Array | |||
Get-TypeData System.Array | Should Be $null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this test? Maybe remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just add it by analogy to other existing test. If you think, that it is not necessary here, then I can remove that last commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this test using on-page edit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daxian-dbw You could just remove one last commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PetSerAl Yes. I made this change with the online editor. But I'm going to squash and merge, so it should be fine.
@PetSerAl Thanks for the contribution! |
Closes #3222