8000 return HTTP response for error status as part of exception by SteveL-MSFT · Pull Request #3201 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

return HTTP response for error status as part of exception #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 25, 2017
Merged

return HTTP response for error status as part of exception #3201

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0d8be7b
added http response to new HttpResponseException to provide similar e…
SteveL-MSFT Feb 24, 2017
6fe216a
fixed bad merge
SteveL-MSFT Feb 24, 2017
1920187
added http response to new HttpResponseException to provide similar e…
SteveL-MSFT Feb 24, 2017
8483c7c
sealed HttpResponseException class, used auto-accessors, removed unus…
SteveL-MSFT Feb 24, 2017
5dd0b5f
Merge branch 'weberror'
SteveL-MSFT Feb 24, 2017
eaaaa7f
derived HttpResponseException from HttpRequestException so other catc…
SteveL-MSFT Feb 25, 2017
4a8e693
added try..catch around reading response stream and checking if detai…
SteveL-MSFT Feb 25, 2017
4a420db
added try..catch..finally around reading response stream and checking…
SteveL-MSFT Feb 25, 2017
c3c939f
Merge branch 'master' of github.com:SteveL-MSFT/PowerShell
SteveL-MSFT Feb 25, 2017
4b1e21c
remove accidentally included file
SteveL-MSFT Feb 25, 2017
8fbe863
move allocation of StreamReader into try block
SteveL-MSFT Feb 25, 2017
650839b
Add null check before disposing `reader`
daxian-dbw Feb 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...erShell.Commands.Utility/commands/utility/WebCmdlet/CoreCLR/WebRequestPSCmdlet.CoreClr.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,9 +383,10 @@ protected override void ProcessRecord()
HttpResponseException httpEx = new HttpResponseException(message, response);
ErrorRecord er = new ErrorRecord(httpEx, "WebCmdletWebResponseException", ErrorCategory.InvalidOperation, request);
string detailMsg = "";
StreamReader reader = new StreamReader(StreamHelper.GetResponseStream(response));
StreamReader reader = null;
try
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using try-catch-finally to avoid nesting

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member
@daxian-dbw daxian-dbw Feb 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2xmax do you mean like this?

StreamReader reader = null;
try
{
  reader = new StreamReader(StreamHelper.GetResponseStream(response))
  ....
}
catch { }
finally { if (reader != null) { reader.Dispose(); } }

{
reader = new StreamReader(StreamHelper.GetResponseStream(response));
// remove HTML tags making it easier to read
detailMsg = System.Text.RegularExpressions.Regex.Replace(reader.ReadToEnd(), "<[^>]*>","");
}
Expand Down
0