8000 Get-ComputerInfo - fix typo in property name by iSazonov · Pull Request #3167 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Get-ComputerInfo - fix typo in property name #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2017
Merged

Get-ComputerInfo - fix typo in property name #3167

merged 1 commit into from
Feb 17, 2017

Conversation

iSazonov
Copy link
Collaborator

Close #3166

@PowerShellTeam PowerShellTeam added the Review - Needed The PR is being reviewed label Feb 17, 2017
@joeyaiello
Copy link
Contributor

You're so fast, @iSazonov! I'm just waking up, you're already fixing 4 hour old issues. 😄

@daxian-dbw daxian-dbw self-assigned this Feb 17, 2017
@iSazonov
Copy link
Collaborator Author

@joeyaiello I still thought for a long time-to be or not to be :-)

@daxian-dbw daxian-dbw merged commit 88c8be7 into PowerShell:master Feb 17, 2017
@lzybkr lzybkr added the Breaking-Change breaking change that may affect users label Feb 19, 2017
@lzybkr
Copy link
Contributor
lzybkr commented Feb 19, 2017

I added the breaking change label because this is a public api - scripts may be using that property name.

If we're concerned about the break - then would could add an alias.

@iSazonov iSazonov deleted the BiosSeralNumber branch February 20, 2017 03:06
@iSazonov
Copy link
Collaborator Author

@lzybkr I dont see the typo in PS 5.1 (Win 10 build 15031)

@lzybkr
Copy link
Contributor
lzybkr commented Feb 20, 2017

I do:

#13 PS> [Microsoft.PowerShell.Commands.ComputerInfo].GetProperty('BiosSeralNumber')

MemberType       : Property
Name             : BiosSeralNumber
DeclaringType    : Microsoft.PowerShell.Commands.ComputerInfo
ReflectedType    : Microsoft.PowerShell.Commands.ComputerInfo
MetadataToken    : 385876785
Module           : Microsoft.PowerShell.Commands.Management.dll
PropertyType     : System.String
Attributes       : None
CanRead          : True
CanWrite         : True
GetMethod        : System.String get_BiosSeralNumber()
SetMethod        : Void set_BiosSeralNumber(System.String)
IsSpecialName    : False
CustomAttributes : {}

#14 PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.14393.693
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.693
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

@iSazonov
Copy link
Collaborator Author

Sorry. I confirm.

@iSazonov iSazonov removed the Review - Needed The PR is being reviewed label Mar 27, 2017
@ncook-hxgn
Copy link

This seems to still be a problem on 5.1 (which I have across a group of computers. I don't see it in PS 7.0.3 which I run locally / develop in) .. which version was this fixed in?
I think what I mean to ask is, is a fix for this available via Windows Update for WMF 5.1?

A43D

@iSazonov
Copy link
Collaborator Author

@ncook-hxgn Windows PowerShell is frozen - no functional updates, only security ones. All new features are in only in PowerShell 7+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees

@daxian-dbw daxian-dbw

Labels
Breaking-Change breaking change that may affect users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get-ComputerInfo Typo - BiosSeralNumber
7 participants
@iSazonov @joeyaiello @lzybkr @ncook-hxgn @daxian-dbw @PowerShellTeam @msftclas
0