8000 adds parameter sets to web cmdlets to allow for standard and non-stan… by 0x4c6565 · Pull Request #3142 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

adds parameter sets to web cmdlets to allow for standard and non-stan… #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 6, 2017
Merged

adds parameter sets to web cmdlets to allow for standard and non-stan… #3142

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7c11001
adds parameter sets to web cmdlets to allow for standard and non-stan…
0x4c6565 Feb 13, 2017
8f25fd9
add CoreCLI implementation
0x4c6565 Feb 16, 2017
ecf7624
Adds CM alias and notnullempty for CustomMethod parameter
0x4c6565 Feb 16, 2017
51fb2fb
Merge branch 'master' into 3113-allow-nonstandard-verbs
0x4c6565 Mar 2, 2017
5d6763b
Add tests for Invoke-[WebRequest|RestMethod] CustomMethod parameter
0x4c6565 Mar 3, 2017
f5db053
Fix webcmdlet tests - incorrect parameter name
0x4c6565 Mar 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
adds parameter sets to web cmdlets to allow for standard and non-stan… 
…dard method verbs
  • Loading branch information
@0x4c6565
0x4c6565 committed Feb 13, 2017
commit 7c11001976247bb03c92d664bdf20ed9878b9393
12 changes: 11 additions & 1 deletion ...hell.Commands.Utility/commands/utility/WebCmdlet/Common/InvokeRestMethodCommand.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,23 @@ public partial class InvokeRestMethodCommand
/// <summary>
/// gets or sets the parameter Method
/// </summary>
[Parameter]
[Parameter(ParameterSetName = "StandardMethod")]
public override WebRequestMethod Method
{
get { return base.Method; }
set { base.Method = value; }
}

/// <summary>
/// gets or sets the parameter CustomMethod
/// </summary>
[Parameter(ParameterSetName = "CustomMethod")]
Copy link
Contributor
@thezim thezim Feb 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make this validate on input and removed the checks for IsNullOrEmpty. Also adding an alias now would be nice.

[ValidateNotNullOrEmpty]
[Alias("CM")]

public override string CustomMethod
{
get { return base.CustomMethod; }
set { base.CustomMethod = value; }
}

#endregion Parameters

#region Helper Methods
Expand Down
26 changes: 24 additions & 2 deletions ...owerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,14 +147,25 @@ public virtual int MaximumRedirection
/// <summary>
/// gets or sets the Method property
/// </summary>
[Parameter]
[Parameter(ParameterSetName = "StandardMethod")]
public virtual WebRequestMethod Method
{
get { return _method; }
set { _method = value; }
}
private WebRequestMethod _method = WebRequestMethod.Default;

/// <summary>
/// gets or sets the CustomMethod property
/// </summary>
[Parameter(ParameterSetName = "CustomMethod")]
public virtual string CustomMethod
{
get { return _customMethod; }
set { _customMethod = value; }
}
private string _customMethod;

#endregion

#region Proxy
Expand Down Expand Up @@ -547,7 +558,8 @@ private Uri PrepareUri(Uri uri)
IDictionary bodyAsDictionary;
LanguagePrimitives.TryConvertTo<IDictionary>(Body, out bodyAsDictionary);
if ((null != bodyAsDictionary)
&& (Method == WebRequestMethod.Default || Method == WebRequestMethod.Get))
&& ((IsStandardMethodSet() && (Method == WebRequestMethod.Default || Method == WebRequestMethod.Get))
|| (IsCustomMethodSet() && (string.IsNullOrEmpty(CustomMethod) || CustomMethod.ToUpper() == "GET"))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be consistent and use ToUpperInvariant().

{
UriBuilder uriBuilder = new UriBuilder(uri);
if (uriBuilder.Query != null && uriBuilder.Query.Length > 1)
Expand Down Expand Up @@ -626,6 +638,16 @@ private ErrorRecord GetValidationError(string msg, string errorId, params object
return (error);
}

private bool IsStandardMethodSet()
{
return (ParameterSetName == "StandardMethod");
}

private bool IsCustomMethodSet()
{
return (ParameterSetName == "CustomMethod");
}

#endregion Helper Methods
}
}
2 changes: 1 addition & 1 deletion ...ll.Commands.Utility/commands/utility/WebCmdlet/FullClr/InvokeRestMethodCommand.FullClr.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace Microsoft.PowerShell.Commands
/// Intended to work against the wide spectrum of "RESTful" web services
/// currently deployed across the web.
/// </summary>
[Cmdlet(VerbsLifecycle.Invoke, "RestMethod", HelpUri = "https://go.microsoft.com/fwlink/?LinkID=217034")]
[Cmdlet(VerbsLifecycle.Invoke, "RestMethod", HelpUri = "https://go.microsoft.com/fwlink/?LinkID=217034", DefaultParameterSetName = "StandardMethod")]
public partial class InvokeRestMethodCommand : WebRequestPSCmdlet
{
#region Virtual Method Overrides
Expand Down
2 changes: 1 addition & 1 deletion ...ll.Commands.Utility/commands/utility/WebCmdlet/FullClr/InvokeWebRequestCommand.FullClr.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace Microsoft.PowerShell.Commands
/// The Invoke-RestMethod command
/// This command makes an HTTP or HTTPS request to a web server and returns the results.
/// </summary>
[Cmdlet(VerbsLifecycle.Invoke, "WebRequest", HelpUri = "https://go.microsoft.com/fwlink/?LinkID=217035")]
[Cmdlet(VerbsLifecycle.Invoke, "WebRequest", HelpUri = "https://go.microsoft.com/fwlink/?LinkID=217035", DefaultParameterSetName = "StandardMethod")]
public class InvokeWebRequestCommand : WebRequestPSCmdlet
{
#region Virtual Method Overrides
Expand Down
20 changes: 16 additions & 4 deletions ...erShell.Commands.Utility/commands/utility/WebCmdlet/FullClr/WebRequestPSCmdlet.FullClr.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,22 @@ internal virtual WebRequest GetRequest(Uri uri)
request.Proxy = WebSession.Proxy;
}

// set the method if the parameter was provided
if (WebRequestMethod.Default != Method)
switch (ParameterSetName)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this simplified to this. Since CustomMethod will always be null or a real string (param validation) checking for $null should be enough.

// set the custom method if the parameter was provided
            if(CustomMethod != null)
            {
                request.Method = CustomMethod.ToUpperInvariant();
            }
            else
            {
                // set the method if the parameter was provided
                if (WebRequestMethod.Default != Method)
                {
                    request.Method = Method.ToString().ToUpperInvariant();
                }
            }

{
request.Method = Method.ToString().ToUpperInvariant();
case "StandardMethod":
if (WebRequestMethod.Default != Method)
{
// set the method if the parameter was provided
request.Method = Method.ToString().ToUpperInvariant();
}
break;
case "CustomMethod":
// set the method if the parameter was provided
if (!string.IsNullOrEmpty(CustomMethod))
{
request.Method = CustomMethod.ToUpperInvariant();
}
break;
}

// pull in http specific properties
Expand Down Expand Up @@ -248,7 +260,7 @@ internal virtual void FillRequestStream(WebRequest request)
request.ContentType = ContentType;
}
// ContentType == null
else if (Method == WebRequestMethod.Post)
else if (Method == WebRequestMethod.Post || (!string.IsNullOrEmpty(CustomMethod) && CustomMethod.ToUpper() == "POST"))
{
// Win8:545310 Invoke-WebRequest does not properly set MIME type for POST
if (String.IsNullOrEmpty(request.ContentType))
Expand Down
17 changes: 17 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,23 @@ Describe "Invoke-WebRequest tests" -Tags "Feature" {
$result = ExecuteWebCommand -command $command
$result.Error | Should BeNullOrEmpty
}

It "Validate StandardMethod and CustomMethod parameter sets" {

#Validate that parameter sets are functioning correctly
$command = "Invoke-RestMethod -Uri 'http://sandbox.lee.io/method.php' -Method GET -CustomMethod 'TEST'"
$result = ExecuteWebCommand -command $command
$result.Error | Should Not BeNullOrEmpty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use the ShouldBeErrorId pattern, see https://github.com/PowerShell/PowerShell/blob/master/test/powershell/engine/Module/TestModuleManifest.ps1#L50

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactored test to utilise ShouldBeErrorId

}

It "Validate CustomMethod parameter set method is passed" {

#Validate that parameter sets are functioning correctly
$command = "Invoke-RestMethod -Uri 'http://sandbox.lee.io/method.php' -CustomMethod 'TEST'"
$result = ExecuteWebCommand -command $command
$result.Error | Should BeNullOrEmpty
($result.Output | ConvertFrom-Json).method | Should Be "TEST"
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you added code explicitly for when CustomMethod is get or post. You should add tests for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests now added for this

Describe "Invoke-RestMethod tests" -Tags "Feature" {
Expand Down
0