Refactor GetFileShares
#26155
Draft
Refactor GetFileShares
#26155
+72
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbd25d4 to
574a2f5
Compare
* Use unmanaged pointers instead of `nint` * Avoid pointer arithmetic, use Span instead * Fix PInvoke definitions * Avoid `PtrToStructure` and use blittable struct for performance.
574a2f5 to
dd31365
Compare
iSazonov
reviewed
Oct 9, 2025
| public ushort* remark; | ||
| } | ||
|
|
||
| internal static uint NetShareEnum<T>(string? servername, out T* pShareInfo, out int count) where T : unmanaged |
There was a problem hiding this comment.
Since it is high level helper it could return just List so that we have no interop/unsafe code in call site.
There was a problem hiding this comment.
We need to free the unmanaged buffer, so we cannot return just a managed type.
There was a problem hiding this comment.
I considered implementing a class deriving from SafeBuffer, but this would be much more code and abstraction for a method that is only called once.
There was a problem hiding this comment.
If we build List in the method we can free the buffer in the method too.
There was a problem hiding this comment.
If we build List in the method we can free the buffer in the method too.
This is exactly what the GetFileShares method does already :p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nintPtrToStructureand use blittable struct for performance.Follow-up to: #25896