-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update test result processing to use NUnitXml format and enhance logging for better clarity #25288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing for better clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- .github/actions/test/process-pester-results/process-pester-results.ps1: Language not supported
- build.psm1: Language not supported
…tHub Actions compatibility
TravisEz13
commented
Apr 7, 2025
TravisEz13
commented
Apr 7, 2025
adityapatwardhan
approved these changes
Apr 7, 2025
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
Azure Pipelines successfully started running 2 pipeline(s). |
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Apr 11, 2025
…ing for better clarity (PowerShell#25288)
9 tasks
@PowerShell/powershell-maintainers triage decision - required infrastructure change |
pwshBot
pushed a commit
to pwshBot/PowerShell
that referenced
this pull request
Apr 28, 2025
…ing for better clarity (PowerShell#25288)
9 tasks
Sysoiev-Yurii
pushed a commit
to Sysoiev-Yurii/PowerShell
that referenced
this pull request
May 12, 2025
…ing for better clarity (PowerShell#25288)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport-7.4.x-Migrated
Backport-7.5.x-Migrated
CL-BuildPackaging
Indicates that a PR should be marked as a build or packaging change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request includes several changes to improve the logging and error reporting in the test workflows, as well as to update the test result formats. The most important changes include updating the test result format from JUnitXml to NUnitXml, refactoring the process to summarize Pester test results, and enhancing the logging in various scripts.
Test result format updates:
.github/actions/test/nix/action.yml
and.github/actions/test/windows/action.yml
. [1] [2]Refactoring Pester test results processing:
process-pester-results.ps1
in.github/actions/test/process-pester-results/action.yml
.process-pester-results.ps1
to handle the summarization of Pester test results, including more detailed metrics.Enhancing logging:
Write-LogGroupStart
andWrite-LogGroupEnd
calls to group log messages inbuild.psm1
and.github/actions/test/windows/action.yml
. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Formatting improvements:
Show-PSPesterError
andTest-XUnitTestResults
functions inbuild.psm1
for better readability. [1] [2]PR Context
JUnit Test results would often fail to serialize at all or properly. Switching back to NUnit because the format was reliable.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright header