Resolve issue #2478 by adding -TimeOut to Test-Connection #2479
Conversation
|
Hi @jpsnover, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| @@ -128,6 +128,14 @@ public class TestConnectionCommand : PSCmdlet | |||
| public Int32 BufferSize { get; set; } = 32; | |||
|
|
|||
| /// <summary> | |||
| /// The following is the definition of the input parameter "BufferSize". | |||
| /// Buffer size sent with the this command. The default value is 32. | |||
There was a problem hiding this comment.
This comment must be updated. It was copied and pasted without modification.
|
@jpsnover Please include test(s) for this change in ...\test\powershell\Modules\Microsoft.PowerShell.Management @adityapatwardhan and @JamesWTruher Please review |
|
@jpsnover PRs should be sent out from a fork instead of from a branch directly pushed to powershell/powershell. That is to make sure powershell/powershell has a minimal number of branches. Could you please close this PR and send it from a fork after addressing the CR comments? |
| /// </summary> | ||
| [Parameter] | ||
| [ValidateRange((int)1, Int32.MaxValue)] | ||
| public Int32 TimeOut { get; set; } = 1000; |
There was a problem hiding this comment.
1000 [](start = 45, length = 4)
I'm a little worried about this - how did you land on this value? Could the default value be Int32.MaxValue to maintain current behavior? Anyone using this new parameter would likely provide a much smaller number in any case
There was a problem hiding this comment.
MAXValue is clearly too large but that is what the API takes and I'm not sure what a reasonable MAX size would be so I juse use the MAXVALUE
|
This was superseded by PR #2492 |
No description provided.