8000 Update metadata.json by jshigetomi · Pull Request #24764 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]

Skip to content

Update metadata.json #24764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Update metadata.json #24764

merged 2 commits into from
Jan 14, 2025

Conversation

jshigetomi
Copy link
Collaborator
@jshigetomi jshigetomi commented Jan 10, 2025

PR Summary

This pull request updates the release tags in the tools/metadata.json file to reflect the latest versions.

Release tag updates:

  • Updated PreviewReleaseTag from v7.5.0-rc.1 to v7.6.0-preview.2.
  • Updated ReleaseTag from v7.4.6 to v7.6.0-preview.2.
  • Updated NextReleaseTag from v7.5.0-preview.6 to v7.6.0-preview.3.

PR Context

PR Checklist

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-macos

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-linux

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-windows

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-static-analysis

Copy link
No pipelines are associated with this pull request.

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-Windows-Packaging-CI

Copy link
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi
Copy link
Collaborator Author

/azp run PSResourceGet ACR

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-static-analysis

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi jshigetomi marked this pull request as ready for review January 10, 2025 23:15
@TravisEz13 TravisEz13 marked this pull request as draft January 10, 2025 23:18
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 10, 2025
@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-linux

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-macos

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-windows

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link
azure-pipelines bot commented 8000 Jan 13, 2025
Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi
Copy link
Collaborator Author

/azp run PSResourceGet ACR

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-static-analysis

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-Windows-Packaging-CI

Copy link
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-linux

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi
Copy link
Collaborator Author

/azp run PowerShell-CI-linux

Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@jshigetomi jshigetomi marked this pull request as ready for review January 14, 2025 18:41
@jshigetomi jshigetomi merged commit a69452e into master Jan 14, 2025
41 checks passed
@jshigetomi jshigetomi deleted the metadata branch January 14, 2025 18:42
Copy link
Contributor
microsoft-github-policy-service bot commented Jan 14, 2025

A3E2 Hey @jshigetomi, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@mjcheetham
Copy link
mjcheetham commented Jan 14, 2025

@jshigetomi, since the PR was merged the "https://aka.ms/install-powershell.ps1" script fails when run on a Windows ARM64 machine with the following arguments:

$installScript = "$env:TEMP\install-powershell.ps1"
Invoke-WebRequest -Uri "https://aka.ms/install-powershell.ps1" -OutFile $installScript
& $installScript -AddToPath

An exception is thrown saying the following URL is 404-ing:

https://powershellinfraartifacts-gkhedzdeaghdezhr.z01.azurefd.net/install/v7.6.0-preview2/PowerShell-7.6.0-preview.2-win-arm64.zip

Comes from line 374 in the script:

        $metadata = Invoke-RestMethod https://raw.githubusercontent.com/PowerShell/PowerShell/master/tools/metadata.json
        if ($Preview) {
            $release = $metadata.PreviewReleaseTag -replace '^v'
        } else {
            $release = $metadata.ReleaseTag -replace '^v'
        }

        if ($IsWinEnv) {
            if ($UseMSI) {
                $packageName = "PowerShell-${release}-win-${architecture}.msi"
            } else {
                $packageName = "PowerShell-${release}-win-${architecture}.zip"
            }
        } elseif ($IsLinuxEnv) {
            $packageName = "powershell-${release}-linux-${architecture}.tar.gz"
        } elseif ($IsMacOSEnv) {
            $packageName = "powershell-${release}-osx-${architecture}.tar.gz"
        }

        $downloadURL = "https://github.com/PowerShell/PowerShell/releases/download/v${release}/${packageName}"
        Write-Verbose "About to download package from '$downloadURL'" -Verbose

        $packagePath = Join-Path -Path $tempDir -ChildPath $packageName
        if (!$PSVersionTable.ContainsKey('PSEdition') -or $PSVersionTable.PSEdition -eq "Desktop") {
            # On Windows PowerShell, progress can make the download significantly slower
            $oldProgressPreference = $ProgressPreference
            $ProgressPreference = "SilentlyContinue"
        }

        try {
****        Invoke-WebRequest -Uri $downloadURL -OutFile $packagePath ****
        } finally {
            if (!$PSVersionTable.ContainsKey('PSEdition') -or $PSVersionTable.PSEdition -eq "Desktop") {
                $ProgressPreference = $oldProgressPreference
            }
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0