8000 Fix alpine tar package name and do not crossgen alpine fxdependent package by adityapatwardhan · Pull Request #20459 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix alpine tar package name and do not crossgen alpine fxdependent package #20459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2023
Merged

Fix alpine tar package name and do not crossgen alpine fxdependent package #20459

merged 4 commits into from
Oct 9, 2023

Conversation

adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Oct 9, 2023 •
edited
Loading

PR Summary

There was regression in previous release where the name of the alpine package as created as *-linux-linux-musl.tar.gz. This PR fixes it to *-linux-musl.tar.gz

There was a regression 2 releases ago where the fxdependent alpine package was getting crossgen'ed. This PR fixes it to be not crossgen'ed

PR Context

Fixes #20177

PR Checklist

@adityapatwardhan adityapatwardhan merged commit a24e954 into PowerShell:master Oct 9, 2023
@adityapatwardhan adityapatwardhan deleted the FixAlpineNamesCrossGen branch October 9, 2023 21:54
adityapatwardhan added a commit that referenced this pull request Oct 19, 2023
@adityapatwardhan
Fix alpine tar package name and do not crossgen alpine fxdependent pa…
f8b0ae3 
…ckage (#20459)
@adityapatwardhan adityapatwardhan mentioned this pull request Oct 19, 2023
Merged
adityapatwardhan added a commit that referenced this pull request Oct 19, 2023
@adityapatwardhan
Fix alpine tar package name and do not crossgen alpine fxdependent pa…
e60125d 
…ckage (#20459) (#20536)
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 18, 2024
chrisdent-de pushed a commit to chrisdent-de/PowerShell that referenced this pull request Sep 12, 2024
@adityapatwardhan @chrisdent-de
Fix alpine tar package name and do not crossgen alpine fxdependent pa…
3fad584 
…ckage (PowerShell#20459) (PowerShell#20536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees
No one assigned
Labels
BackPort-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Powershell v7.4.0-preview.5 Alpine nupkg doubled in size doubled compared to v7.4.0-preview.3
3 participants
@adityapatwardhan @TravisEz13 @daxian-dbw
0