Add Tests to Language #2043
Add Tests to Language #2043
Conversation
|
Hi @bingbing8, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
@JamesWTruher Can you review this PR? |
|
the files run by Pester must end with Tests.ps1 - none of the tests are actually being run. |
| $err = $null | ||
| try | ||
| { | ||
| dir nosuchfile.nosuchextension -ea stop -ev err |
There was a problem hiding this comment.
dir [](start = 16, length = 3)
get-childitem please
There was a problem hiding this comment.
I'm going to be pedantic but -ea & -ev should be expanded here as well
|
🕐 |
|
|
||
| It 'Check basic expressions' { | ||
|
|
||
| {2+2}.CheckRestrictedLanguage($null, $null, $false) # Succeed with no variables |
There was a problem hiding this comment.
is there supposed to be a should statement here?
{ {2+2}.CheckRestrictedLanguage($null, $null, $false)} | Should Not Throw
There was a problem hiding this comment.
Updated all tests.
|
this is a pretty big PR, is there any way to break it up? |
|
Hi @bingbing8, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
|
I closed and re-opened PR to retrigger Travis CI webhook (build payload was not delivered last time). I seen this behavior quite a few times. @PowerShell/powershell-maintainers any ideas why it happening? Should we include something about such cases in our maintainers docs? |
|
I will close the request and split it to multiple for easy review. |
Add Tests to Language feature.