10000 Fix `Test-Connection` due to .NET 8 changes by SteveL-MSFT · Pull Request #20369 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Fix Test-Connection due to .NET 8 changes #20369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2023
Merged

Fix Test-Connection due to .NET 8 changes #20369

merged 4 commits into from
Oct 2, 2023

Conversation

SteveL-MSFT
Copy link
Member
@SteveL-MSFT SteveL-MSFT commented Sep 25, 2023 •
edited
Loading

PR Summary

.NET 8 made a change on how a custom buffer works on Linux, so we have to change the code to use a default empty buffer so that .NET uses its own default buffer. A custom buffer size requires sudo on Linux.

PR Context

Fix #17018

PR Checklist

@SteveL-MSFT SteveL-MSFT mentioned this pull request Sep 25, 2023
Closed
2 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 25, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 25, 2023
@iSazonov
Copy link
Collaborator

If this cmdlet is running with elevated permissions on Linux, why not just check for those permissions for certain parameters and report an error if needed?

(As far as I remember there is a way to set up ping for a regular user too. I don't think it's necessary to complicate our installer, but all this could be simply reflected in the documentation. Or we could create something like Enable-PSRemoting.)

@SteveL-MSFT SteveL-MSFT added this to the 7.4-Consider milestone Sep 28, 2023
daxian-dbw
daxian-dbw approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 2, 2023
@pull-request-quantifier-deprecated
Copy link

This PR has 10 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +4 -6
Percentile : 4%

Total files changed: 1

Change summary by file extension:
.cs : +4 -6

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw merged commit 63178bb into PowerShell:master Oct 2, 2023
@daxian-dbw daxian-dbw removed this from the 7.4-Consider milestone Oct 2, 2023
@JoeSalmeri
Copy link

What pwsh version has this fix for Test-Connection ?

I tried 7.4.0-preview.6 but still requires sudo on Linux

@adityapatwardhan adityapatwardhan mentioned this pull request Oct 19, 2023
Merged
adityapatwardhan pushed a commit that referenced this pull request Oct 20, 2023
@SteveL-MSFT @adityapatwardhan
Fix Test-Connection due to .NET 8 changes (#20369)
3eefec1
adityapatwardhan added a commit that referenced this pull request Oct 20, 2023
@adityapatwardhan
Fix Test-Connection due to .NET 8 changes (#20369) (#20531)
240bd1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees

@daxian-dbw daxian-dbw

Labels
BackPort-7.4.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test-Connection needs to be revised due to an intentional breaking change in .NET 7
5 participants
@SteveL-MSFT @iSazonov @JoeSalmeri @daxian-dbw @adityapatwardhan
0