8000 Add mariner arm64 package build to release build by anamnavi · Pull Request #19946 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Add mariner arm64 package build to release build #19946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 20, 2023
Merged

Add mariner arm64 package build to release build #19946

merged 10 commits into from
Jul 20, 2023

Conversation

anamnavi
Copy link
Member
@anamnavi anamnavi commented Jul 12, 2023 •
edited
Loading

PR Summary

Add mariner arm64 package build to release build

PR Context

PR Checklist

@pull-request-quantifier-deprecated
Copy link

This PR has 106 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Medium
Size       : +97 -9
Percentile : 41.2%

Total files changed: 6

Change summary by file extension:
.psm1 : +30 -4
.yml : +67 -5

Change counts above are quantified counts, based on the PullRequestQuantifier cust 8000 omizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

adityapatwardhan
adityapatwardhan requested changes Jul 17, 2023
View reviewed changes
Copy link
Member
@adityapatwardhan adityapatwardhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a update to the expected package names here:

PowerShell/tools/releaseBuild/azureDevOps/templates/release-ValidatePackageNames.yml

Lines 33 to 35 in 3ce65f3

Get-ChildItem $(System.ArtifactsDirectory)\* -recurse -filter *.rpm | ForEach-Object {
if($_.Name -notmatch 'powershell\-(preview-|lts-)?\d+\.\d+\.\d+(_[a-z]*\.\d+)?-1.(rh|cm).x86_64\.rpm')
{

@microsoft-github-policy-service microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 17, 2023
@StevenBucher98 StevenBucher98 added the PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed label Jul 17, 2023
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jul 17, 2023
@TravisEz13 TravisEz13 merged commit d712c45 into PowerShell:master Jul 20, 2023
@TravisEz13
Copy link
Member

@PowerShell/powershell-maintainers We will defer backporting to LTS until we have more data.

@daxian-dbw daxian-dbw mentioned this pull request Sep 11, 2023
Merged
daxian-dbw pushed a commit that referenced this pull request Sep 11, 2023
@anamnavi @daxian-dbw
Add mariner arm64 package build to release build (#19946)
2a01164
daxian-dbw added a commit that referenced this pull request Sep 11, 2023
@daxian-dbw
[release/v7.3.7] Add mariner arm64 package build to release build (#1…
3c7009c 
…9946) (#20250)
adityapatwardhan pushed a commit that referenced this pull request Oct 24, 2023
@anamnavi @adityapatwardhan
Add mariner arm64 package build to release build (#19946)
3229c83
@adityapatwardhan adityapatwardhan mentioned this pull request Oct 24, 2023
Merged
adityapatwardhan added a commit that referenced this pull request Oct 24, 2023
@adityapatwardhan
Add mariner arm64 package build to release build (#19946) (#20566)
5d5382b
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an 9506 account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@daxian-dbw daxian-dbw

@TravisEz13 TravisEz13

@adityapatwardhan adityapatwardhan

@iSazonov iSazonov

@SeeminglyScience SeeminglyScience

Labels
Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Medium PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anamnavi @TravisEz13 @adityapatwardhan @daxian-dbw @StevenBucher98 @iSazonov @SeeminglyScience
0