8000 Publish rpm package for rhel9 by TravisEz13 · Pull Request #19750 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Publish rpm package for rhel9 #19750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2023
Merged

Publish rpm package for rhel9 #19750

merged 1 commit into from
Jul 10, 2023

Conversation

TravisEz13
Copy link
Member
@TravisEz13 TravisEz13 commented Jun 6, 2023 •
edited
Loading

PR Summary

PR Context

PR Checklist

@TravisEz13 TravisEz13 marked this pull request as draft June 6, 2023 00:37
@TravisEz13 TravisEz13 added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Backport-7.2.x-Consider PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed labels Jun 6, 2023
@kilasuit kilasuit mentioned this pull request Jun 6, 2023
Closed
14 tasks
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jun 9, 2023
@ghost ghost added the Stale label Jun 24, 2023
@ghost
Copy link
ghost commented Jun 24, 2023

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Jul 4, 2023
@kilasuit kilasuit reopened this Jul 5, 2023
@pull-request-quantifier-deprecated
Copy link

This PR has 5 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +5 -0
Percentile : 2%

Total files changed: 1

Change summary by file extension:
.json : +5 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost removed the Stale label Jul 5, 2023
@TravisEz13 TravisEz13 marked this pull request as ready for review July 5, 2023 19:55
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 5, 2023
daxian-dbw
daxian-dbw approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 5ec04f1 into master Jul 10, 2023
@daxian-dbw daxian-dbw deleted the TravisEz13-patch-1 branch July 10, 2023 21:06
@daxian-dbw daxian-dbw mentioned this pull request Sep 11, 2023
Merged
daxian-dbw pushed a commit that referenced this pull request Sep 11, 2023
@TravisEz13 @daxian-dbw
Publish rpm package for rhel9 (#19750)
ee38291
daxian-dbw added a commit that referenced this pull request Sep 11, 2023
@daxian-dbw
[release/v7.2.14] Publish rpm package for rhel9 (#19750) (#20234)
5ecbec3
@daxian-dbw daxian-dbw mentioned this pull request Sep 11, 2023
Merged
daxian-dbw pushed a commit that referenced this pull request Sep 11, 2023
@TravisEz13 @daxian-dbw
Publish rpm package for rhel9 (#19750)
e3742fa
daxian-dbw added a commit that referenced this pull request Sep 11, 2023
@daxian-dbw
[release/v7.3.7] Publish rpm package for rhel9 (#19750) (#20245)
b10ca5f
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees
No one assigned
Labels
Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small PowerShell-Docs needed The PR was reviewed and a PowerShell Docs update is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
0