8000 Update to .NET 8 Preview 4 by adityapatwardhan · Pull Request #19696 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Update to .NET 8 Preview 4 #19696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for Git 8000 Hub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jun 21, 2023
Merged

Update to .NET 8 Preview 4 #19696

merged 25 commits into from
Jun 21, 2023

Conversation

adityapatwardhan
Copy link
Member

PR Summary

  • Update to .NET 8 Preview 4
  • Fix SYSLIB0051
  • Fix SYSLIB0050

PR Context

PR Checklist

@ghost ghost assigned daxian-dbw May 23, 2023
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 23, 2023
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 24, 2023
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 24, 2023
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 24, 2023
daxian-dbw
daxian-dbw reviewed May 24, 2023
View reviewed changes
daxian-dbw
daxian-dbw reviewed May 25, 2023
View reviewed changes
Copy link
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are protected constructors removed like the following 2. Should them be kept with an obsolete attribute? I didn't try finding all the places with this same issue, so please go over your changes and see if there are more instances of this.

@ghost ghost added the Review - Needed The PR is being reviewed label Jun 2, 2023
@ghost
Copy link
ghost commented Jun 2, 2023

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@StevenBucher98 StevenBucher98 added the PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update label Jun 5, 2023
daxian-dbw
daxian-dbw requested changes Jun 19, 2023
View reviewed changes
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jun 19, 2023
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Jun 21, 2023
@daxian-dbw
Copy link
Member

@adityapatwardhan Please fix the CI failures.

@pull-request-quantifier-deprecated
Copy link

This PR has 885 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Large
Size       : +225 -660
Percentile : 96.17%

Total files changed: 106

Change summary by file extension:
.json : +27 -35
.config : +1 -1
.cs : +174 -600
.csproj : +23 -23
.ps1 : +0 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive F438 a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

daxian-dbw
daxian-dbw approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @adityapatwardhan!

@adityapatwardhan adityapatwardhan merged commit ebe0b54 into PowerShell:master Jun 21, 2023
@adityapatwardhan adityapatwardhan deleted the updateNET8p4 branch June 21, 2023 22:17
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 21, 2023
@ghost
Copy link
ghost commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@crlogic crlogic mentioned this pull request Jul 2, 2023
Closed
Samenstau
Samenstau reviewed Jul 7, 2023
View reviewed changes
Copy link
@Samenstau Samenstau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@daxian-dbw daxian-dbw mentioned this pull request Jul 17, 2023
Merged
22 tasks
@daxian-dbw daxian-dbw mentioned this pull request May 13, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 left review comments

@iSazonov iSazonov iSazonov left review comments

@Samenstau Samenstau Samenstau left review comments

@PaulHigin PaulHigin PaulHigin requested changes

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@daxian-dbw daxian-dbw

Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Large PowerShell-Docs not needed The PR was reviewed and doesn't appear to require a PowerShell Docs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adityapatwardhan @daxian-dbw @TravisEz13 @PaulHigin @iSazonov @Samenstau @StevenBucher98
0