8000 Restructure the package build to simplify signing and packaging stages by adityapatwardhan · Pull Request #19321 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Restructure the package build to simplify signing and packaging stages #19321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Mar 14, 2023
Merged

Restructure the package build to simplify signing and packaging stages #19321

merged 39 commits into from
Mar 14, 2023

Conversation

adityapatwardhan
Copy link
Member

PR Summary

Re-structure the release build to simplify the packaging and signing stages. More changes will be made to simplify linux build and packaging in future PRs.

PR Context

PR Checklist

@adityapatwardhan
< 10000 a title="Only build assemblies" data-pjax="true" class="Link--secondary markdown-title" href="/PowerShell/PowerShell/pull/19321/commits/4e5c3e212935f9db583cf435acaee67af35db196">Only build assemblies
4e5c3e2
@adityapatwardhan
Remove signfiles stage
24384ea
@adityapatwardhan
Add signing for files
39a45e3
@adityapatwardhan
Fix matrix name
a590b70
@adityapatwardhan
Fix template call
c131544
@adityapatwardhan
Fix deps
a93ca75
@adityapatwardhan
Remove macos signing dep
c3d75fa
@adityapatwardhan
Fix condition
63201b0
@adityapatwardhan
fix typo
76d7d9f
@adityapatwardhan
fix typo 2
8e8ce80
@adityapatwardhan
Update variables to be runtime variables
27d8668
@adityapatwardhan
Fix download
5fe78cf
@adityapatwardhan
Fix quotes
03bb412
@adityapatwardhan
Add packaging and package signing
d22142c
@adityapatwardhan
Remove mac deps
5334f9d
@adityapatwardhan
Re-order nuget
16efa63
@adityapatwardhan
Re-order steps
a2dfeca
@adityapatwardhan
Fix paths
0fc5184
@adityapatwardhan
Add self checkout
dab9714
@adityapatwardhan
Fix indent
d8f3e19
@adityapatwardhan
fix mariner package name and paths
99444c0
@adityapatwardhan
fix display names
3b3cf26
@adityapatwardhan
Fix paths for downloaded files
01a1db0
@adityapatwardhan
Fix errors
223c209
@adityapatwardhan
Expand symbols zip
c5f6153
@adityapatwardhan
Fix misc issues
47fc47a
@adityapatwardhan
Add variables to signing job
5a7afef
@adityapatwardhan
Update pool and checkout paths
7fb66a6
@adityapatwardhan
Fix the typo
5c247e4
@adityapatwardhan
Fix path
88f9028
@ghost ghost assigned daxian-dbw Mar 13, 2023
TravisEz13
TravisEz13 reviewed Mar 13, 2023
View reviewed changes
tools/releaseBuild/azureDevOps/releaseBuild.yml

strategy:
matrix:
linux-x64:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider dynamically producing the matrix, so we can move it into a single JSON in our repo as we need this matrix in more places.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that as part of the next iteration, i need to split the deb build and packaging.

@pull-request-quantifier-deprecated
Copy link

This PR has 514 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Large
Size       : +425 -89
Percentile : 83.8%

Total files changed: 11

Change summary by file extension:
.yml : +425 -89

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

daxian-dbw
daxian-dbw approved these changes Mar 13, 2023
View reviewed changes
Copy link
< 8000 /div>
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 13, 2023
@adityapatwardhan adityapatwardhan merged commit 7bca828 into PowerShell:master Mar 14, 2023
@adityapatwardhan adityapatwardhan deleted the restructionBuild branch March 14, 2023 02:22
@ghost
Copy link
ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@adityapatwardhan adityapatwardhan mentioned this pull request Mar 15, 2023
Merged
22 tasks
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Apr 12, 2023
8000
@adityapatwardhan @daxian-dbw
Restructure the package build to simplify signing and packaging stages (
1c7ec2f 
PowerShell#19321)
@ghost
Copy link
ghost commented Apr 13, 2023

🎉v7.2.11 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link
ghost commented Apr 13, 2023

🎉v7.3.4 has been released which incorporates this pull request.:tada:

Handy links:

adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 25, 2023
@adityapatwardhan @daxian-dbw
Restructure the package build to simplify signing and packaging stages (
2642167 
PowerShell#19321)
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@daxian-dbw daxian-dbw

Labels
Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityapatwardhan @daxian-dbw @TravisEz13
0