8000 Use reference assemblies generated by dotnet by adityapatwardhan · Pull Request #19302 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Use reference assemblies generated by dotnet #19302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 9, 2023
Merged

Use reference assemblies generated by dotnet #19302

merged 14 commits into from
Mar 9, 2023

Conversation

adityapatwardhan
Copy link
Member

PR Summary

GenAPI tool is deprecated and does not work anymore. We are using reference assemblies generated during the build.

We use Linux-x64 ref assemblies for common modules and win7-x64 assemblies for windows only modules.

Microsoft.Powershell.SDK only has ref assemblies for common modules between windows and linux.

PR Context

PR Checklist

@ghost ghost assigned iSazonov Mar 9, 2023
@adityapatwardhan adityapatwardhan enabled auto-merge (squash) March 9, 2023 19:02
@adityapatwardhan adityapatwardhan merged commit e9a25c7 into PowerShell:master Mar 9, 2023
@adityapatwardhan adityapatwardhan deleted the NewRefAsm branch March 9, 2023 19:41
@adityapatwardhan adityapatwardhan mentioned this pull request Mar 9, 2023
Closed
5 tasks
@pull-request-quantifier-deprecated
Copy link

This PR has 101 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Medium
Size       : +68 -33
Percentile : 40.2%

Total files changed: 3

Change summary by file extension:
.psm1 : +22 -23
.yml : +46 -10

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 14, 2023
@ghost
Copy link
ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Apr 12, 2023
@adityapatwardhan @daxian-dbw
Use reference assemblies generated by dotnet (PowerShell#19302)
347dfa3
@ghost
Copy link
ghost commented Apr 13, 2023

🎉v7.2.11 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link
ghost commented Apr 13, 2023

🎉v7.3.4 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Apr 18, 2023
Closed
Closed
adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 25, 2023
@adityapatwardhan @daxian-dbw
Use reference assemblies generated by dotnet (PowerShell#19302)
ac5cfc6
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@iSazonov iSazonov

Labels
Backport-7.2.x-Done Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adityapatwardhan @TravisEz13 @daxian-dbw @iSazonov
0