8000 Refactor `MUIFileSearcher.AddFiles` by xtqqczze · Pull Request #18825 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Refactor MUIFileSearcher.AddFiles #18825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2023
Merged

Refactor MUIFileSearcher.AddFiles #18825

merged 3 commits into from
May 1, 2023

Conversation

xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Dec 19, 2022 •
edited
Loading
  • Use custom EnumerationOptions for ensure case insensitivity on Linux (available since .NET Core 2.1).
  • Use Directory.EnumerateFiles instead of Directory.GetFiles to avoid allocations (contributes to Replace GetFiles with EnumerateFiles #14318)

@ghost ghost assigned PaulHigin Dec 19, 2022
@iSazonov
Copy link
Collaborator

I wonder why you are trying to update the edge code. :-)

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 23, 2022
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 23, 2022
@xtqqczze
Copy link
Contributor Author
xtqqczze commented Dec 23, 2022 •
edited
Loading

I wonder why you are trying to update the edge code. :- 8000 )

@iSazonov Sorry, could you clarify what you mean?

@iSazonov
Copy link
Collaborator

What I mean is that you are wasting your time on help subsystem code that should have been upgraded as a whole a long time ago...

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 26, 2022
@xtqqczze
Copy link
Contributor Author

See also:

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Dec 30, 2022
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 10, 2023
@xtqqczze xtqqczze closed this Jan 10, 2023
@xtqqczze xtqqczze reopened this Jan 10, 2023
@pull-request-quantifier-deprecated
Copy link

This PR has 29 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +6 -23
Percentile : 11.6%

Total files changed: 1

Change summary by file extension:
.cs : +6 -23

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 13, 2023
@ghost ghost added the Stale label Jan 28, 2023
@ghost
Copy link
ghost commented Jan 28, 2023

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@xtqqczze xtqqczze marked this pull request as ready for review January 29, 2023 03:16
@ghost ghost removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept Stale labels Jan 29, 2023
@ghost ghost added the Review - Needed The PR is being reviewed label Feb 5, 2023
@ghost
Copy link
ghost commented Feb 5, 2023

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

daxian-dbw
daxian-dbw approved these changes May 1, 2023
View reviewed changes
Copy link
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label May 1, 2023
@daxian-dbw daxian-dbw merged commit 31bc65e into PowerShell:master May 1, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label May 1, 2023
@ghost
Copy link
ghost commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

Assignees

@PaulHigin PaulHigin

Labels
CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xtqqczze @iSazonov @daxian-dbw @PaulHigin
0