8000 Replace `UTF8Encoding(false)` with `Encoding.Default` by xtqqczze · Pull Request #18144 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Replace UTF8Encoding(false) with Encoding.Default #18144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 27, 2022
Merged

Replace UTF8Encoding(false) with Encoding.Default #18144

merged 4 commits into from
Sep 27, 2022

Conversation

xtqqczze
Copy link
Contributor
@xtqqczze xtqqczze commented Sep 21, 2022 •
edited
Loading

8000
@ghost ghost assigned iSazonov Sep 21, 2022
@xtqqczze
don't use StandardInputEncoding
e81bcab
@xtqqczze
fix SA1500
9a0645c 
If a statement spans multiple lines, the opening curly bracket must be placed on its own line.
iSazonov
iSazonov reviewed Sep 22, 2022
View reviewed changes
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Sep 22, 2022
daxian-dbw
daxian-dbw reviewed Sep 22, 2022
View reviewed changes
Copy link
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall with a minor comment. Thanks for making this change @xtqqczze!

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 25, 2022
@pull-request-quantifier-deprecated
Copy link

This PR has 36 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +21 -15
Percentile : 14.4%

Total files changed: 5

Change summary by file extension:
.cs : +21 -15

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context pro 8000 file.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 26, 2022
@xtqqczze xtqqczze marked this pull request as ready for review September 26, 2022 22:28
@xtqqczze xtqqczze requested a review from PaulHigin as a code owner September 26, 2022 22:28
@xtqqczze xtqqczze changed the title Use Encoding.Default Replace UTF8Encoding(false) with Encoding.Default Sep 26, 2022
@iSazonov
Copy link
Collaborator

@daxian-dbw Can you approve?

daxian-dbw
daxian-dbw approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov merged commit fd67038 into PowerShell:master Sep 27, 2022
@iSazonov
Copy link
Collaborator

@xtqqczze Thanks!

@xtqqczze xtqqczze deleted the Encoding.Default branch September 27, 2022 20:41
@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
Merged
22 tasks
@xtqqczze xtqqczze mentioned this pull request Oct 23, 2022
Merged
@unfurl-links unfurl-links bot mentioned this pull request Nov 11, 2022
Closed
5 tasks
@ghost
8000 Copy link
ghost commented Dec 20, 2022

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@iSazonov iSazonov iSazonov approved these changes

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@iSazonov iSazonov

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtqqczze @iSazonov @daxian-dbw
0