8000 Update `DotnetRuntimeMetadata.json` for .NET 7 RC1 build by adityapatwardhan · Pull Request #18091 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

Update DotnetRuntimeMetadata.json for .NET 7 RC1 build #18091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2022
Merged

Update DotnetRuntimeMetadata.json for .NET 7 RC1 build #18091

merged 4 commits into from
Sep 15, 2022

Conversation

adityapatwardhan
Copy link
Member
@adityapatwardhan adityapatwardhan commented Sep 14, 2022 •
edited
Loading

PR Summary

Update the metadata json to take .NET 7 RC1 build. Pinning SDK version as there is a bug which points to the wrong build.

PR Context

PR Checklist

@ghost ghost assigned daxian-dbw Sep 14, 2022
daxian-dbw
daxian-dbw approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member
@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

daxian-dbw
daxian-dbw reviewed Sep 14, 2022
View reviewed changes
@adityapatwardhan adityapatwardhan mentioned this pull request Sep 14, 2022
Closed
@pull-request-quantifier-deprecated
8000
Copy link

This PR has 98 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Small
Size       : +49 -49
Percentile : 39.2%

Total files changed: 13

Change summary by file extension:
.json : +5 -5
.wxs : +15 -15
.csproj : +29 -29

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw merged commit 29ddf44 into PowerShell:master Sep 15, 2022
@adityapatwardhan adityapatwardhan deleted the UpdateNET7RC1 branch September 15, 2022 21:59
@adityapatwardhan
Copy link
Member Author

/backport to release/v7.3.0-rc.1

@github-actions
Copy link
Contributor

@adityapatwardhan backporting to release/v7.3.0-rc.1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Update `DotnetRuntimeMetadata.json` for .NET 7 RC1 build
Applying: Bump to .NET 7 RC1 and related package updates
Using index info to reconstruct a base tree...
M	src/Microsoft.PowerShell.Commands.Utility/Microsoft.PowerShell.Commands.Utility.csproj
Falling back to patching base and 3-way merge...
Auto-merging src/Microsoft.PowerShell.Commands.Utility/Microsoft.PowerShell.Commands.Utility.csproj
CONFLICT (content): Merge conflict in src/Microsoft.PowerShell.Commands.Utility/Microsoft.PowerShell.Commands.Utility.csproj
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Bump to .NET 7 RC1 and related package updates
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this pull request Sep 15, 2022
@adityapatwardhan
Update DotnetRuntimeMetadata.json for .NET 7 RC1 build (PowerShell#…
cc14abd 
…18091)
@adityapatwardhan adityapatwardhan mentioned this pull request Sep 15, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
Merged
22 tasks
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 20, 2022
@ghost
Copy link
ghost commented Dec 20, 2022

🎉v7.4.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@daxian-dbw daxian-dbw

Labels
Backport-7.3.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityapatwardhan @daxian-dbw
0